feat: use new not-config-file stl #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
approved these changes
Nov 7, 2023
WillieRuemmele
approved these changes
Nov 8, 2023
| @@ -20,6 +20,7 @@ describe('source:deploy --destructive NUTs', () => { | |||
| const pathToClass = path.join(testkit.projectDir, output, `${apexName}.cls`); | |||
| execCmd(`force:apex:class:create --classname ${apexName} --outputdir ${output} --api-version 58.0`, { | |||
| ensureExitCode: 0, | |||
| cli: 'sf', | |||
There was a problem hiding this comment.
if we're using cli: 'sf' we can remove PDR as a dev-dep and oclif dev-plugin right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
well, see, it all started when I wanted to pull in forcedotcom/source-tracking#496
but then I bumped devScripts, too.
node:And hey, we might as well get rid of some oclif.devPlugins and use the
cli:sfpattern insteadOh, now we're no longer needing shelljs, so that can go.
Wait, now that we've gotten rid of so many devDeps, it's easy to see some that aren't being used anymore (and probably haven't since the
sfifificationwork)Sorry.
What issues does this PR fix or reference?
rollout of @W-14399468@