fix: more flag conflicts #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
reviewed
Jun 6, 2023
| @@ -65,11 +66,6 @@ export class Retrieve extends SourceCommand { | |||
| summary: messages.getMessage('flags.retrievetargetdir.summary'), | |||
| exclusive: ['packagenames', 'sourcepath'], | |||
| }), | |||
| apiversion: Flags.string({ | |||
There was a problem hiding this comment.
api-version was on the command, but another api-version was the one actually being used in the code below. I think this was just to get a char alias the hard way, but that meant api-version was being ignored.
WillieRuemmele
approved these changes
Jun 6, 2023
| public static readonly state = 'deprecated'; | ||
| public static readonly deprecationOptions = { | ||
| to: replacement, | ||
| message: messages.getMessage('deprecation', [replacement]), | ||
| }; | ||
| public static readonly flags = { | ||
| 'api-version': orgApiVersionFlagWithDeprecations, | ||
| // I have no idea why 'a' isn't matching the type AlphabetLowercase automatically | ||
| 'api-version': { ...orgApiVersionFlagWithDeprecations, char: 'a' as AlphabetLowercase }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created via github action [skip-validate-pr]