fix: remove -o conflict, add short char UTs, add short chars to NUTs #821
Conversation
| summary: messages.getMessage('flags.targetusername.summary'), | ||
| parse: async (input: string | undefined) => resolveUsername(input), | ||
| default: async () => resolveUsername(), | ||
| defaultHelp: async () => resolveUsername(), |
There was a problem hiding this comment.
Is this correct for defaultHelp?
There was a problem hiding this comment.
This is similar to what we did in plugin-org
There was a problem hiding this comment.
This form can leak customer data into the manifest.
There was a problem hiding this comment.
| @@ -75,6 +80,7 @@ export class Deploy extends DeployCommand { | |||
| summary: messages.getMessage('flags.runTests.summary'), | |||
| }), | |||
| ignoreerrors: Flags.boolean({ | |||
| // break this | |||
There was a problem hiding this comment.
What does this comment mean?
There was a problem hiding this comment.
leftover - will remove
| summary: messages.getMessage('flags.targetusername.summary'), | ||
| parse: async (input: string | undefined) => resolveUsername(input), | ||
| default: async () => resolveUsername(), | ||
| defaultHelp: async () => resolveUsername(), |
There was a problem hiding this comment.
This form can leak customer data into the manifest.
| @@ -259,3 +271,26 @@ export const getCoverageFormattersOptions = (formatters: string[] = []): Coverag | |||
| reportOptions, | |||
| }; | |||
| }; | |||
|
|
|||
| export const targetUsernameFlag = Flags.string({ | |||
There was a problem hiding this comment.
Having target-org with short char other than 'o' break sf guidelines. I ran into short char collision in plugin-user and to avoid the collision we ended up retaining the old commands that used the -o and created new ones that allows style adherence.
What does this PR do?
removes
-ochar duplication onsource/mdapi:deployadds NUTs that uses short options
adds UTs that use short options
What issues does this PR fix or reference?
@W-13056553@
forcedotcom/cli#2080