fix: pass --soapdeploy flag to method, add org-metadata #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
commented
Apr 14, 2023
| @@ -121,7 +121,9 @@ export abstract class DeployCommand extends SourceCommand { | |||
| return false; | |||
| } | |||
|
|
|||
| const restDeployConfig = this.configAggregator.getInfo(SfdxPropertyKeys.REST_DEPLOY).value; | |||
| const restDeployConfig = | |||
There was a problem hiding this comment.
if you run sf force:source:deploy the configAggregator will be a ConfigAggregator not a SfdxConfigAggregator which won't know about the sf config values
mshanemc
reviewed
Apr 17, 2023
mshanemc
approved these changes
Apr 17, 2023
|
QA: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
passes
--soapdeployflag to method that requires itadds support for
org-metadata-rest-deployconfig where it was usingSfdxConfigAggergatorWhat issues does this PR fix or reference?
@W-13036560@
forcedotcom/cli#2062