Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default for wait on mdapi:report commands #804

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Apr 7, 2023

What does this PR do?

sets a default on the wait flag on both mdapi report commands.

What issues does this PR fix or reference?

@W-12992146@

@mshanemc mshanemc requested a review from WillieRuemmele April 7, 2023 14:44
@WillieRuemmele
Copy link
Contributor

QA Notes


before:

 ➜  sfdx force mdapi deploy report -i 0AfDE00002bXw5z0AC                                                         
Warning: We plan to deprecate this command in the future. Try using the "project deploy report" command instead.
Error (1): Cannot read properties of undefined (reading 'minutes')
➜  dreamhouse-lwc git:(main)  hub:(DevHub) scratch:([email protected])

after: ✅

 ➜  ../../oss/plugin-source/bin/dev force:mdapi:deploy:report -i 0AfDE00002bXw5z0AC       
Warning: We plan to deprecate this command in the future. Try using the "project deploy report" command instead.
Deploy ID: 0AfDE00002bXw5z0AC
Status: Succeeded
Deployed: 91/91 Errors: 0
Tests Complete: 0/0 Errors: 0

👀 : maybe a bug in the PDR code... we might be assuming there's a cache, or if we can't find a cache, we should query the server - that job still exists there

 ➜  sfdx project deploy report --job-id 0AfDE00002bXw5z0AC
Error (1): No job found for ID: 0AfDE00002bXw5z0AC.

@WillieRuemmele WillieRuemmele merged commit 63bd14d into main Apr 7, 2023
@WillieRuemmele WillieRuemmele deleted the sm/flag-failures-for-2042 branch April 7, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants