feat: display replacements on push/deploy #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -117,6 +122,22 @@ export class DeployResultFormatter extends ResultFormatter { | |||
| return get(this.result, 'response', {}) as MetadataApiDeployStatus; | |||
| } | |||
|
|
|||
| protected displayReplacements(): void { | |||
| if (this.isVerbose() && this.result.replacements?.size) { | |||
There was a problem hiding this comment.
only displaying replacements with --verbose? Same comment for pushResultFormatter below too
I would expect if there were any replacements, they'd be displayed without needing another flag?
There was a problem hiding this comment.
for deploy, I could go either way. It felt noisy, like a thing I wouldn't want / pay attention to unless something weird was happening and I needed to investigate.
for push, they'll be there by default because it already has a quiet mode which omits them (from human and json). Or at least that's what I meant.
WillieRuemmele
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
display for humans and json for
replacementson push/deployWhat issues does this PR fix or reference?
@W-11949818@