fix: display error message from response #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
approved these changes
Oct 17, 2022
Comment on lines
+89
to
+94
| let errMsg = ''; | ||
| this.results?.forEach((res) => { | ||
| if (res.response?.errorMessage) { | ||
| errMsg += `${res.response?.errorMessage}\n`; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Is \n fine across os ? Or do you need the EOL thing?
Suggested change
| let errMsg = ''; | |
| this.results?.forEach((res) => { | |
| if (res.response?.errorMessage) { | |
| errMsg += `${res.response?.errorMessage}\n`; | |
| } | |
| }); | |
| const errMsg = this.results?.filter((res) => res.response?.errorMessage).join('\n') |
| @@ -102,6 +102,26 @@ describe('PushResultFormatter', () => { | |||
| expect(headerStub.callCount, JSON.stringify(headerStub.args)).to.equal(1); | |||
| expect(tableStub.callCount, JSON.stringify(tableStub.args)).to.equal(1); | |||
| }); | |||
| it('should output as expected for a deploy failure (GACK)', async () => { | |||
| const errorMessage = | |||
| 'UNKNOWN_EXCEPTION: An unexpected error occurred. Please include this ErrorId if you contact support: 1730955361-49792 (-1117026034)'; | |||
|
QA notes repro'd per Steves fork and instructions. This was actually a failure: this branch...never been so excited to see a GACK ✅ ✅ also see a gack via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a deploy fails without any component failures the command was not showing the errorMessage field that is set on the response. This PR adds that error message to the error thrown by the command.
What issues does this PR fix or reference?
@W-11905229@
For Testing:
Deploy code that will cause a GACK. I have a repro for you.
sfdx force:source:deploy -p force-appsfdx force:mdapi:deploysfdx force:source:push