fix: exclude sourcepath from component set builder #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
approved these changes
Aug 11, 2022
| @@ -110,7 +110,7 @@ export class Retrieve extends SourceCommand { | |||
|
|
|||
| protected async retrieve(): Promise<void> { | |||
| const packagenames = this.getFlag<string[]>('packagenames'); | |||
| if (!packagenames) { | |||
| if (!packagenames && !this.flags.unpackaged) { | |||
There was a problem hiding this comment.
yep, that should solve it.
WillieRuemmele
approved these changes
Aug 15, 2022
QA Notes:previously would parse the local FS to build a comp. set, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exclude passing a sourcepath to the ComponentSetBuilder when the
unpackagedflag is set. Theunpackagedflag is the path to the manifest and the command should only use the manifest, not consider any local source path.What issues does this PR fix or reference?
@W-11588116@