Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try/finally on pollStatus to handle throws from timeout #538

Merged
merged 5 commits into from
Jul 18, 2022

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

try/finally on pollStatus for both mdapi:deploy:report and source:deploy:report
after the deploy times out, it uses the this.report one more time to get a good in-progress DeployResult

What issues does this PR fix or reference?

forcedotcom/cli#1612
@W-11431588@

QA notes

I used EDA to get a really slow deploy like the customer has

# eda is weird with its scratch orgs and namespace, so
sfdx force:org:create -d 1 -f orgs/dev.json --nonamespace -s
# convert source for mdapi deploy
sfdx force:source:convert -d force-app --outputdir=mdapiOut

steps based on the customer's logic. Have these ready to copy/paste quickly

../../plugin-source/bin/dev force:mdapi:deploy --deploydir mdapiOut --ignorewarnings -w 0 --testlevel RunLocalTests --json
# but use the job id from your deploy
../../plugin-source/bin/dev force:mdapi:deploy:report -i 0Af1k00001PyBXhCAN --wait 1 --json
# verifying fix for source:deploy
../../plugin-source/bin/dev force:source:deploy:report -i 0Af1k00001PyBXhCAN --wait 1 --json

Screen Shot 2022-07-14 at 2 35 37 PM

@shetzel shetzel merged commit 68ff738 into main Jul 18, 2022
@shetzel shetzel deleted the sm/json-output-timeouts-report branch July 18, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants