fix: default min line number to 1 when 100 pct coverage #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-11221748@ Math.min with no params is Infinity. Default to 1 when array is empty
mshanemc
approved these changes
May 31, 2022
WillieRuemmele
approved these changes
May 31, 2022
mshanemc
pushed a commit
that referenced
this pull request
May 31, 2022
@W-11221748@ Math.min with no params is Infinity. Default to 1 when array is empty
iowillhoit
added a commit
that referenced
this pull request
Jun 15, 2022
* feat: remove dependence on SDR registry.apiVersion * fix: manifest create uses sourceApiVersion as fallback from flag * fix: use SDR 6.0 * refactor: sfdxError => sfError from SDR * test: disable lifecycle event tests (temporary) * test: nut updates for ebikes-lwc (utam) * feat: adjust for new sf paths * fix: mdapi deploy negative one * fix: ternary tweaks * fix: -1 for mdapi:report, 0 for mdapi:deploy, -1 for retrieve * refactor: consistent use of duration/freq for mdapi * test: adjust for new parameter structure * fix: remove ugly debug statement * refactor: consistent use of pollStatus object param * fix: correct default for deploy:report * fix: allow -1 for retrieve report * refactor: report can be async * refactor: common parking orbit changes for msg/error/table * refactor: SfProject * test: updates for oclif and passing UT * refactor: message effects of sfdxError.create() * fix: sfdxCommand leaves SfError * test: expect sfError * test: all nuts are passing locally * feat: add code coverage and junt reports to deploy and deploy report @ * chore: bump jsforce * chore: ensure miss when looking for source files * chore: apply review comments * chore: apply review changes requests * chore: bump core * chore: bump sdr * chore: redo snapshot * chore: parking orbit version of STL * test: restore hooks tests * chore: bump sdr * chore: dedupe yarn * refactor: isolate deployCommand messages * test: mock globalinfo * chore: snapshot for new coverage flags * chore: bump oclif/core * chore: remove oclif/config * chore: ts-next is happier * test: more nuts manually to bin/dev * test: sfError * test: executable for --tracksource flag nut * chore: more renaming from coverage reporters * chore: snapshot * test: bin/dev for nested lwc * chore: bump dev plugins to parking-orbit versions * chore: bin/dev on source-testkit * refactor: redundant executable * fix: default min line number to 1 when 100 pct coverage (#494) @W-11221748@ Math.min with no params is Infinity. Default to 1 when array is empty * feat: tests use new testkit versions, defaulting to bin/dev * refactor: type cleanup * chore: more type fix * fix: test and nut for deploy coverage reports * chore: bump source-testkit * fix: code from main * chore: bump core, let deps use their core version * test: don't assign permsets that don't exist in repo * test: fix rest delpoyments for --validate after --checkonly * chore: bump testkit for rm retries * test: make test match describe/it * ci: higher timeout * test: nuts more likely to catch the "silent ghost error" * test: report non-json result * chore: circle debug tracking (revert me) * test: always clear globalinfo for cpTestkit * chore: bump core for stateAggregator * Revert "chore: circle debug tracking (revert me)" This reverts commit 5959883. * chore: bump testkits * ci: check keychain * ci: revert environment * ci: nuts with updated context plus async nuts * ci: bump testkits again * ci: build with resolution to test branch * ci: v3 resolutions won't allow command-ref/snapshots * ci: use core with crypto cache fix * chore: dependencies * test: make sure setup and prep commands are successful * chore: bump core for stateAggregator and crypto cache fix * feat: bump sdr for mdapi fault protection * ci: not the async nuts again * fix: use CliUx from oclif/core * ci: restore post-test script [ci-skip] * chore: remove cli-ux (use oclif/core) * ci: restore v4 release plugin * style: remove -a from source:status examples * feat: delete has stdout for "checkonly" * feat: you must provide some retrieve target * fix: use correct table column in deploy errors * refactor: move check only messaging to prompt * feat: success messages for deploy * style: messages end in periods * test: adjust ut for success log * test: update nuts for ebikes changes * refactor: correct flag name Co-authored-by: Eric Willhoit <[email protected]> Co-authored-by: Peter Hale <[email protected]> Co-authored-by: peternhale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Math.min with no params is Infinity. Default to 1 when array is empty
What issues does this PR fix or reference?
@W-11221748@