-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mdapi deploy negative one #487
Conversation
QA Notes
|
Tested again with recent changes, LGTM |
SOAP and REST ✅ |
What does this PR do?
mdapi:deploy/retrieve/report has special treatment for
-w -1
indefinitely long waits should be the default for retrieve/report
help text was reporting default twice
explanation:
This is in the plugin instead of SDR to avoid changing the behavior there and reduce the scope of this "feature" to just
mdapi:deploy
this uses milliseconds because polling client eventually will be using ms. using max_safe_int for something larger (ex: minutes) would probably break something when it gets converted to ms.
fix logger's fail on circular dependency forcedotcom/cli#1518
What issues does this PR fix or reference?
forcedotcom/cli#1519
forcedotcom/cli#1518
forcedotcom/cli#1511 (about help being wrong)
@W-11147622@
@W-11150198@