Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mdapi deploy negative one #487

Merged
merged 10 commits into from
May 17, 2022
Merged

fix: mdapi deploy negative one #487

merged 10 commits into from
May 17, 2022

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented May 16, 2022

What does this PR do?

mdapi:deploy/retrieve/report has special treatment for -w -1
indefinitely long waits should be the default for retrieve/report

help text was reporting default twice

explanation:
This is in the plugin instead of SDR to avoid changing the behavior there and reduce the scope of this "feature" to just mdapi:deploy
this uses milliseconds because polling client eventually will be using ms. using max_safe_int for something larger (ex: minutes) would probably break something when it gets converted to ms.

fix logger's fail on circular dependency forcedotcom/cli#1518

What issues does this PR fix or reference?

forcedotcom/cli#1519
forcedotcom/cli#1518
forcedotcom/cli#1511 (about help being wrong)
@W-11147622@
@W-11150198@

@mshanemc mshanemc requested review from iowillhoit and peternhale May 16, 2022 13:46
@iowillhoit
Copy link
Contributor

QA Notes
I was able to pass -w -1 on all of the modified commands:

sfdx force:mdapi:deploy -d metadataPackage_1652718790193 -w -1
sfdx force:mdapi:deploy:report -w -1
sfdx force:mdapi:retrieve -r temp/retrieve-dir -w -1

@iowillhoit
Copy link
Contributor

Tested again with recent changes, LGTM

@shetzel
Copy link
Contributor

shetzel commented May 17, 2022

SOAP and REST
sfdx force:mdapi:deploy -d converted/ -l RunLocalTests -w -1
sfdx force:mdapi:deploy -d converted/ -l RunLocalTests -w 0
sfdx force:mdapi:deploy -d converted/ -l RunLocalTests
sfdx force:mdapi:deploy -d converted/ -l RunLocalTests -w 100
sfdx force:mdapi:deploy:report -i 0Af9A00000Z7DxUSAV -w 0
sfdx force:mdapi:deploy:report -i 0Af9A00000Z7DxUSAV -w 0 --json
sfdx force:mdapi:deploy:report -i 0Af9A00000Z7DxUSAV
sfdx force:mdapi:deploy:report -i 0Af9A00000Z7DxUSAV -w -1
sfdx force:mdapi:deploy:report -i 0Af9A00000Z7ETuSAN --json
sfdx force:mdapi:deploy:report -i 0Af9A00000Z7FfXSAV -w 100

sfdx force:mdapi:retrieve -r retrieved -k package.xml
sfdx force:mdapi:retrieve -r retrieved -k package.xml -w -1
sfdx force:mdapi:retrieve -r retrieved -k package.xml -w 0
sfdx force:mdapi:retrieve:report -r retrieved -w 100 --json
sfdx force:mdapi:retrieve:report -r retrieved -w 0
sfdx force:mdapi:retrieve:report -r retrieved -w -1
sfdx force:mdapi:retrieve:report

@shetzel shetzel merged commit c7e2494 into main May 17, 2022
@shetzel shetzel deleted the sm/mdapi-deploy-negative-one branch May 17, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants