fix: add variable polling times based on comp. set #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WillieRuemmele not sure if this helps, but the underlying module ts-retry-promise has configuration options that allow one to specify a non-linear delays. |
mshanemc
reviewed
Jan 3, 2022
There was a problem hiding this comment.
I'm not opposed to this being in plugin-source. Thinking of sf and vscode and other potential users...
would it make more sense to put this in SDR since it would have a component set already? Then if the user didn't specify some polling interval, your calculated intervals would be the default behavior?
mshanemc
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds variable polling frequency to deploy/push/pull/retrieve
I ended up creating a piece-wise function to capture "small" vs "medium" vs "large" vs "larger" deploys - I'm very open to changing the boundaries and frequencies each should return. I did notice a difference between 250ms and 100ms
What issues does this PR fix or reference?
@W-9586672@
requires forcedotcom/source-deploy-retrieve#520