Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditionally include folder #309

Merged
merged 1 commit into from
Nov 23, 2021
Merged

fix: conditionally include folder #309

merged 1 commit into from
Nov 23, 2021

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Nov 20, 2021

What does this PR do?

only include the folder ListMetadataQuery for jsForce's connection.metadata.list when it's a folder type. Even an undefined folder value causes problems for the ListView type.

What issues does this PR fix or reference?

@W-10203090@

@iowillhoit
Copy link
Contributor

QA: Confirmed that ListView meta data was not displayed before this fix and is displaying after the fix. Also listed a few other metadata types post-update and everything appears to be fine 👍

Screen Shot 2021-11-23 at 10 41 59 AM

Screen Shot 2021-11-23 at 10 42 17 AM

Screen Shot 2021-11-23 at 10 45 47 AM

@iowillhoit iowillhoit merged commit 6a7c936 into main Nov 23, 2021
@iowillhoit iowillhoit deleted the sh/mdapi-list-fix branch November 23, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants