Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warning label for source:open #231

Merged
merged 2 commits into from
Sep 29, 2021
Merged

feat: warning label for source:open #231

merged 2 commits into from
Sep 29, 2021

Conversation

mshanemc
Copy link
Contributor

What does this PR do?
adds security warning for the output of source:open (AT in URL)

What issues does this PR fix or reference?
@W-9953835@

@mshanemc mshanemc requested review from shetzel and maggiben and removed request for shetzel September 29, 2021 16:46
shetzel
shetzel approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@shetzel shetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but NUTs are not passing reliably anymore and we need to address that.

@cristiand391 cristiand391 merged commit 62c7161 into main Sep 29, 2021
@cristiand391 cristiand391 deleted the sm/security-warnings branch September 29, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiand391 cristiand391 cristiand391 approved these changes

@shetzel shetzel shetzel approved these changes

@maggiben maggiben Awaiting requested review from maggiben

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshanemc @shetzel @cristiand391