fix: remote-only deletes now supported #220
Conversation
src/commands/force/source/delete.ts
Outdated
| @@ -174,7 +176,7 @@ export class Delete extends DeployCommand { | |||
|
|
|||
| private deleteFilesLocally(): void { | |||
| if (!this.getFlag('checkonly') && getString(this.deployResult, 'response.status') === 'Succeeded') { | |||
| this.sourceComponents.map((component) => { | |||
| this.componentSet.toArray().map((component: SourceComponent) => { | |||
There was a problem hiding this comment.
componentSet.toArray is going to have to iterate the whole thing (and it's a generator so it has to call next() on all of them) https://github.com/forcedotcom/source-deploy-retrieve/blob/aa79e2642a7aa35b05cb71c9f4cc0b0c21c21123/src/collections/lazyCollection.ts#L59
Perf idea: do that once and store it somewhere (ex: this.componentSetAsArray) to use in the various places.
| @@ -174,7 +176,7 @@ export class Delete extends DeployCommand { | |||
|
|
|||
| private deleteFilesLocally(): void { | |||
| if (!this.getFlag('checkonly') && getString(this.deployResult, 'response.status') === 'Succeeded') { | |||
| this.sourceComponents.map((component) => { | |||
| this.componentSet.toArray().map((component: SourceComponent) => { | |||
| // delete the content and/or the xml of the components | |||
| if (component.content) { | |||
| const stats = fs.lstatSync(component.content); | |||
There was a problem hiding this comment.
I'd also suggest thinking through if it's possible to parallelize these via Promise.all (ex: read all the files and build the file list of what needs to be deleted, then await all those deletes in a Promise.all).
I'm thinking of our windows fs pains. Again, perhaps not a big deal for deletes.
|
This is looking good @WillieRuemmele. QA'd this with the old plugin-source and then with your changes. Tried the following and all looks good: Retrieved w/ prompts |
What does this PR do?
source:deletewould fail when trying to delete metadata that was only present in the org, and not locallynow it will delete remote-only metadata
What issues does this PR fix or reference?
@W-9892375@