fix: add verbose test detail when deploying with tests #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
approved these changes
Jul 27, 2021
| @@ -155,4 +161,103 @@ export class DeployResultFormatter extends ResultFormatter { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| protected verboseTestFailures(): void { | |||
| if (this.result.response.numberTestErrors) { | |||
There was a problem hiding this comment.
any possibility of response being undefined and this throwing clumsily? Using this.result?.response?.[etc] would still skip the rest of this method.
| }); | ||
|
|
||
| return uncoveredLines.join(','); | ||
| }, |
There was a problem hiding this comment.
map is more performant and some customers have really large test suites.
Suggested change
| }, | |
| return (Array.isArray(locationsNotCovered) ? locationsNotCovered : [locationsNotCovered]) | |
| .map(uncoveredLine => uncoveredLine.line) | |
| .join(','); |
shetzel
requested changes
Jul 28, 2021
shetzel
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds verbose testing output on deploy
What issues does this PR fix or reference?
@W-9622493@
requires forcedotcom/source-deploy-retrieve#395