Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw deploy error when missing required params #150

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

cristiand391
Copy link
Member

What does this PR do?

Adds a check to ensure user has provided a required flag before deploying source.

What issues does this PR fix or reference?

@W-9586707@

Copy link
Contributor

@shetzel shetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@WillieRuemmele WillieRuemmele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet first PR 👍

@WillieRuemmele WillieRuemmele merged commit 234c596 into main Jul 26, 2021
@WillieRuemmele WillieRuemmele deleted the cd/W-9586707 branch July 26, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants