feat: add env display command #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
approved these changes
Jun 8, 2021
amphro
approved these changes
Jun 8, 2021
| } | ||
| } | ||
| }, | ||
| "Optional<AnyJson>": { |
There was a problem hiding this comment.
I don't think we should have AnyJson or any of these types in the return types
There was a problem hiding this comment.
I think this comes from the return type being SfOrgs which is SfOrg[] which has a union with SfEntry which equals JsonMap which extends Dictionary<AnyJson>.
env display or env list don't do anything with AnyJson explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
sf env displaycommand as specified in this design doc.What issues does this PR fix or reference?
@W-9103917@