Update messages for new sandbox resume command #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
reviewed
Apr 19, 2022
messages/create.sandbox.md
Outdated
| @@ -68,13 +68,21 @@ Type of sandbox license. | |||
|
|
|||
| Number of minutes to wait for the sandbox org to be ready. | |||
|
|
|||
| # flags.wait.description | |||
|
|
|||
| If the command continues to run after the wait period, the CLI returns control of the terminal to you and displays the job ID. To check the status of the sandbox creation, run "sf env resume sandbox". | |||
There was a problem hiding this comment.
When the command times out the following is emitted
Run "sf env resume sandbox --job-id 0GR4p000000U8VmGAK -o [email protected]" to check for status.
There was a problem hiding this comment.
Thx @peternhale . I updated the description, let me know if it's okay. Does the command also display that very useful message if one specifies the --async command?
peternhale
approved these changes
Apr 22, 2022
peternhale
added a commit
that referenced
this pull request
Apr 27, 2022
* feat: add env create sandbox command @W-10657688@ * chore: create sandbox cresate schema * chore: fix target-org summary message * chore: fix misalign message file load * chore: more message corrections * chore: get nut tests running - almost * chore: fixup stub to ux styled header * chore: gen snapshot.json * chore: revert functions to 1.5.0 * Update sandbox.ts * chore: move message to markdown * Update src/commands/env/create/sandbox.ts Co-authored-by: Rodrigo Espinosa de los Monteros <[email protected]> * chore: apply requested review comments * chore: cleaning up and tests * chore: fix failing test update snapshot * Update src/commands/env/create/sandbox.ts Co-authored-by: Shane McLaughlin <[email protected]> * feat: commands to delete scratch orgs and sandboxes * feat: delete scratch org and sboxes * chore: snapshot * chore: hi, schema * refactor: specifc return type for sbox * chore: schema one more time * refactor: target-org * refactor: consolidate flags and confirmation-prompt * refactor: use new Flags from plugins-core * chore: bump dependencies * chore: merge deps * chore: bump deps for latest flag * test: fix typo * test: nuts without setting envs * fix: summary, not description * Update src/commands/env/delete/sandbox.ts Co-authored-by: Rodrigo Espinosa de los Monteros <[email protected]> * refactor: move confirm to sfCommand * test: ut fixes from env:create sbox branch * chore: dependency bumps * ci: tsconfig to build oclif/core from top-level * chore: bump plugins-core * test: copy open test from Pete's branch Co-authored-by: Rodrigo Espinosa de los Monteros <[email protected]> * chore: apply review suggestions * reenable nuts * chore: get nuts ready to run * Update sandboxCreate.nut.ts * chore: isolate sandbox nuts from others * chore: fix circle config * chore: run sandbox nuts [sb-nuts] * Revert "chore: run sandbox nuts [sb-nuts]" This reverts commit f4c014f. * Updated config.yml * chore: force [sb-nuts] * chore: force [sb-nuts] * chore: run [sb-nuts] * chore: [sb-nuts] * chore: revert temp orb reference [skip ci] * Review messages for "env create sandbox" (#254) * Update create.sandbox.md * wire up new flag descriptions * feat: add sandbox create [skip ci] * chore: remove unneeded artifacts * chore: provide better messaging on timeout * chore: mark command as beta * feat: scratch org async/resume * test: nut for scratch async/resume * feat: use orgConfig, not definitionJson * chore: standardColors * chore: resume sandbox and tweaks from testing * refactor: pr feedback * chore: better handle exceptions * chore: aync-wait 0 exist with exit code 68 with latest progress * fix: remove duplicate identified * chore: add clone option * chore: add type to flags * chore: fix stuff * chore: apply review suggestions * chore: fix duplicate output * chore: apply review comments * chore: tweaks * chore: remove alias and set-default from resume * chore: fix char for clone and make license and clone exclusive * chore: fix retention of alias and set default username * chore: improve flags * chore: fix job dependency * Update messages for new sandbox resume command (#271) * update messages for "sf env create sandbox" * update command to take new flag descriptions * edit messages for "sf env resume sandbox" * update command with changes I made to messages * edit * add pete's comment * chore: check * edit messages for resume scratch (#270) * edit "sf env resume scratch" * update command to pickup job-id description * udpate messages for "sf env resume scratch" * pick up the two new descriptions * add note about job ids are valid for 24 hours. * add tech review comments from Shane * chore: correct schma and snapshot * chore: update sfdx-core version and some others * chore: improve type usage * chore: fix imports * chore: eat after all errors when trying to delete session.dir * chore: fix sandbox nuts [sb-nuts] Co-authored-by: Rodrigo Espinosa de los Monteros <[email protected]> Co-authored-by: Shane McLaughlin <[email protected]> Co-authored-by: Juliet Shackell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Edits messages for new "sf env resume sandbox" command, and updates other messages that are affected by new command.
What issues does this PR fix or reference?
@W-11013650@