Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return environments keyed by environment type #148

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Conversation

peternhale
Copy link
Contributor

What does this PR do?

Reorganizes list data from array to object, keyed by env type

What issues does this PR fix or reference?

@W-9922044@

cli.table(table.data, columns, { ...tableOpts, title: table.title });
this.log();
if (
Object.entries(columns).some(([, value]) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you extract this to a method so that it's easier to read?

messages/list.md Outdated Show resolved Hide resolved
Co-authored-by: Juliet Shackell <[email protected]>
@mdonnalley mdonnalley merged commit e677462 into main Sep 23, 2021
@mdonnalley mdonnalley deleted the phale/W-9922044 branch September 23, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants