Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use external template for 3PP plugin generator #143

Merged
merged 4 commits into from
Sep 20, 2022

Conversation

mdonnalley
Copy link
Collaborator

What does this PR do?

Utilize https://github.com/salesforcecli/plugin-template-sf-external for generating 3PP plugins

What issues does this PR fix or reference?

@W-11781515@

@mdonnalley mdonnalley self-assigned this Sep 20, 2022
@cristiand391
Copy link
Member

QA notes:

2pp plugin

🟢 can build it, run UTs and NUTs.
🟢 description is saved to pjson
🟢 env display hook works
🟡 name validator only allows plugin-[a-z], can't use plugin-deploy-retrieve, plugin-internal-test, etc.

3pp plugin
sf dev generate plugin (external)
sf dev generate command execute:apex`

🟢 can build it, run UTs and NUTs.
🟢 description is saved to pjson
🟢 code cov choice is respected (selected 90%, removed a command UT, nyc throws:

ERROR: Coverage for lines (84.61%) does not meet global threshold (90%)
ERROR: Coverage for functions (50%) does not meet global threshold (90%)
ERROR: Coverage for branches (0%) does not meet global threshold (90%)
ERROR: Coverage for statements (84.61%) does not meet global threshold (90%)

@mdonnalley mdonnalley merged commit f002e6a into main Sep 20, 2022
@mdonnalley mdonnalley deleted the mdonnalley/use-external-template branch September 20, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants