Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent NaN in stage output #1139

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix: prevent NaN in stage output #1139

merged 1 commit into from
Aug 22, 2024

Conversation

mdonnalley
Copy link
Collaborator

What does this PR do?

Prevent NaN% from showing in stage output by not showing source tracking progress is there are no source members. Also added a if statement in formatProgress to avoid dividing by 0

Screenshot 2024-08-22 at 12 31 14 PM

What issues does this PR fix or reference?

[skip-validate-pr]

@mshanemc mshanemc merged commit e426bf5 into main Aug 22, 2024
43 checks passed
@mshanemc mshanemc deleted the mdonnalley/avoid-nan branch August 22, 2024 18:17
mdonnalley added a commit that referenced this pull request Aug 26, 2024
mdonnalley added a commit that referenced this pull request Aug 26, 2024
* Revert "fix: prevent NaN in stage output (#1139)"

This reverts commit e426bf5.

* Revert "Merge pull request #1123 from salesforcecli/mdonnalley/ink"

This reverts commit c4f1cff, reversing
changes made to 2098219.
mdonnalley added a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants