fix: support latest-rc releases #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
previously approved these changes
Oct 18, 2021
RodEsp
reviewed
Oct 20, 2021
RodEsp
suggested changes
Oct 20, 2021
RodEsp
reviewed
Oct 25, 2021
peternhale
commented
Oct 25, 2021
RodEsp
suggested changes
Oct 25, 2021
|
@RodEsp digging into pack-and-upload-tarballs I see the pack:verify is called for that step and by the time that tarballs are created, the npm release has already been done, so I assume that pinning deps is not necessary in the pack tarball steps. I adjusted the job "requires" to jobs that actually run in the workflow. Good catches. |
RodEsp
previously approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-10008913@