Release Job #12
Merged
Release Job #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
force-pushed
the
mdonnalley/archives
branch
from
7ebe821 to
55bae1e
Compare
mdonnalley
force-pushed
the
mdonnalley/archives
branch
from
55bae1e to
95a0dc0
Compare
RodEsp
reviewed
Jul 8, 2021
RodEsp
reviewed
Jul 8, 2021
RodEsp
suggested changes
Jul 8, 2021
.circleci/config.yml
Outdated
Comment on lines
97
to
99
| name: node-14 | ||
| - release-management/test-package: | ||
| name: node-12 |
There was a problem hiding this comment.
I know this isn't technically part of your changes but I don't think these lines are actually testing against node 12 and 14 without the node_version parameter.
Can we just change lines 93-99 to match what we have in other repos via Leif?
- release-management/test-package:
matrix:
parameters:
os:
- linux
- windows
node_version:
- latest
- lts
- maintenance
exclude:
- os: windows
node_version: lts
- os: windows
node_version: maintenance
Then we'll need to change the requires of the following jobs to just list - release-management/test-package.
RodEsp
reviewed
Jul 8, 2021
| filters: | ||
| branches: | ||
| only: | ||
| - main | ||
| - release-management/release-package: | ||
| node_version: '14' |
There was a problem hiding this comment.
Suggested change
| node_version: '14' | |
| node_version: 'latest' |
RodEsp
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the circleci jobs for running releases
Depends on salesforcecli/plugin-release-management#231
@W-9499615@