feat: add access token hub auth strategy #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-8066452@
@W-8066452@
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 77.57% 75.12% -2.45%
==========================================
Files 6 6
Lines 379 394 +15
Branches 73 76 +3
==========================================
+ Hits 294 296 +2
- Misses 65 76 +11
- Partials 20 22 +2
Continue to review full report at Codecov.
|
shetzel
requested changes
May 12, 2021
| @@ -9,6 +9,8 @@ describe('hubAuth', () => { | |||
| it('works with existing defaultdevhub if provided'); | |||
| it('auths from authurl in env'); | |||
| it('auths from authurl and sets as default'); | |||
| it('auths from access token and sets as default'); | |||
| it('auths from access token'); | |||
There was a problem hiding this comment.
Are we going to ignore these unit tests forever? Even having NUTs for this would be something. Right now there's nothing.
shetzel
approved these changes
May 13, 2021
peternhale
added a commit
that referenced
this pull request
May 21, 2021
This reverts commit 296df6e.
peternhale
added a commit
that referenced
this pull request
May 24, 2021
peternhale
added a commit
that referenced
this pull request
Jun 10, 2021
This reverts commit 296df6e.
peternhale
added a commit
that referenced
this pull request
Jun 10, 2021
This reverts commit 296df6e.
peternhale
added a commit
that referenced
this pull request
Jun 15, 2021
* chore: add unit tests for hutbauth @W-9270862@ * chore: remove lint error * Revert "fix: add missed export (#91)" This reverts commit 86084c8. * Revert "feat: add access token hub auth strategy (#90)" This reverts commit 296df6e. * Revert "feat: add access token hub auth strategy (#90)" This reverts commit 296df6e. * chore: mock where I can for unit tests * chore: get rid of eslint errors * chore: update some mocking * chore: arrange tests in an order that works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-8066452@