This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some time on the weekend and thought this might be fun. The PR implements a backward ForgetMult for CPU and CUDA and changes to QRNN and QRNNLayer to make them bidirectional. I tried to keep changes to the original code minimal without duplicating a lot of code.
I tested this with Pytorch 0.4.0 and Python 3.6.5. Gradient checks etc. pass. On preliminary results with IMDB movie reviews it looks like a bidirectional QRNN (2 layers, each with forward and backward, 256 hidden units) performs slightly better (~0.5% accuracy) than a unidirectional QRNN of same size (4 layers, 256 hidden units), but I haven't had enough time to finish experiments to be certain on this.
Let me know what you think and where the code still needs changes (I know it's not perfect in some places, especially
QRNNLayer
).