Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): improve error message consistency #969

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

jye-sf
Copy link
Contributor

@jye-sf jye-sf commented Jan 15, 2019

Details

Adds quotes to error messages for better consistency and readability

Does this PR introduce a breaking change?

  • Yes
  • No

@jye-sf jye-sf requested a review from apapko January 15, 2019 22:51
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: c736dbf | Target commit: eb5676e

lwc-engine-benchmark

table-append-1k metric base(c736dbf) target(eb5676e) trend
benchmark-table/append/1k duration 152.50 (±5.35 ms) 150.15 (±3.90 ms) -2.3ms (1.5%) 👍
table-clear-1k metric base(c736dbf) target(eb5676e) trend
benchmark-table/clear/1k duration 6.00 (±0.30 ms) 6.00 (±0.40 ms) 0.0ms (0.0%) 👌
table-create-10k metric base(c736dbf) target(eb5676e) trend
benchmark-table/create/10k duration 921.35 (±6.50 ms) 906.75 (±8.15 ms) -14.6ms (1.6%) 👍
table-create-1k metric base(c736dbf) target(eb5676e) trend
benchmark-table/create/1k duration 120.60 (±3.00 ms) 118.20 (±2.40 ms) -2.4ms (2.0%) 👍
table-update-10th-1k metric base(c736dbf) target(eb5676e) trend
benchmark-table/update-10th/1k duration 77.25 (±3.25 ms) 77.95 (±4.25 ms) +0.7ms (0.9%) 👌
tablecmp-append-1k metric base(c736dbf) target(eb5676e) trend
benchmark-table-component/append/1k duration 254.60 (±7.10 ms) 257.35 (±4.65 ms) +2.8ms (1.1%) 👎
tablecmp-clear-1k metric base(c736dbf) target(eb5676e) trend
benchmark-table-component/clear/1k duration 11.50 (±2.05 ms) 12.10 (±1.65 ms) +0.6ms (5.2%) 👌
tablecmp-create-10k metric base(c736dbf) target(eb5676e) trend
benchmark-table-component/create/10k duration 1789.00 (±23.50 ms) 1741.40 (±15.90 ms) -47.6ms (2.7%) 👍
tablecmp-create-1k metric base(c736dbf) target(eb5676e) trend
benchmark-table-component/create/1k duration 214.80 (±4.60 ms) 215.25 (±5.70 ms) +0.4ms (0.2%) 👌
tablecmp-update-10th-1k metric base(c736dbf) target(eb5676e) trend
benchmark-table-component/update-10th/1k duration 70.40 (±5.25 ms) 71.30 (±4.90 ms) +0.9ms (1.3%) 👌
wc-append-1k metric base(c736dbf) target(eb5676e) trend
benchmark-table-wc/append/1k duration 254.90 (±4.95 ms) 256.75 (±5.30 ms) +1.8ms (0.7%) 👌
wc-clear-1k metric base(c736dbf) target(eb5676e) trend
benchmark-table-wc/clear/1k duration 22.65 (±2.80 ms) 21.85 (±2.15 ms) -0.8ms (3.5%) 👌
wc-create-10k metric base(c736dbf) target(eb5676e) trend
benchmark-table-wc/create/10k duration 1999.00 (±13.25 ms) 1958.85 (±8.95 ms) -40.2ms (2.0%) 👍
wc-create-1k metric base(c736dbf) target(eb5676e) trend
benchmark-table-wc/create/1k duration 226.95 (±3.80 ms) 226.15 (±5.95 ms) -0.8ms (0.4%) 👌
wc-update-10th-1k metric base(c736dbf) target(eb5676e) trend
benchmark-table-wc/update-10th/1k duration 70.20 (±5.50 ms) 71.25 (±4.45 ms) +1.1ms (1.5%) 👌

@caridy caridy merged commit 5c16e22 into master Jan 18, 2019
@caridy caridy deleted the jye/error-message-quotes branch January 18, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants