Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix merge issue in circleci #962

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

pmdartus
Copy link
Member

Details

Fix merging issue that was introduced when rebasing with master the CircleCI config.

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: e94fcbf | Target commit: 0f174ae

lwc-engine-benchmark

table-append-1k metric base(e94fcbf) target(0f174ae) trend
benchmark-table/append/1k duration 149.75 (±4.10 ms) 152.60 (±3.90 ms) +2.8ms (1.9%) 👎
table-clear-1k metric base(e94fcbf) target(0f174ae) trend
benchmark-table/clear/1k duration 6.10 (±0.40 ms) 6.00 (±0.30 ms) -0.1ms (1.6%) 👌
table-create-10k metric base(e94fcbf) target(0f174ae) trend
benchmark-table/create/10k duration 917.85 (±6.50 ms) 921.50 (±6.75 ms) +3.7ms (0.4%) 👎
table-create-1k metric base(e94fcbf) target(0f174ae) trend
benchmark-table/create/1k duration 119.15 (±3.45 ms) 118.75 (±2.85 ms) -0.4ms (0.3%) 👌
table-update-10th-1k metric base(e94fcbf) target(0f174ae) trend
benchmark-table/update-10th/1k duration 86.45 (±4.80 ms) 76.55 (±2.05 ms) -9.9ms (11.5%) 👍
tablecmp-append-1k metric base(e94fcbf) target(0f174ae) trend
benchmark-table-component/append/1k duration 236.45 (±18.75 ms) 253.80 (±7.15 ms) +17.4ms (7.3%) 👎
tablecmp-clear-1k metric base(e94fcbf) target(0f174ae) trend
benchmark-table-component/clear/1k duration 11.50 (±1.45 ms) 11.80 (±1.90 ms) +0.3ms (2.6%) 👌
tablecmp-create-10k metric base(e94fcbf) target(0f174ae) trend
benchmark-table-component/create/10k duration 1782.25 (±18.75 ms) 1804.95 (±21.00 ms) +22.7ms (1.3%) 👎
tablecmp-create-1k metric base(e94fcbf) target(0f174ae) trend
benchmark-table-component/create/1k duration 212.75 (±4.00 ms) 213.90 (±5.65 ms) +1.1ms (0.5%) 👌
tablecmp-update-10th-1k metric base(e94fcbf) target(0f174ae) trend
benchmark-table-component/update-10th/1k duration 70.65 (±4.75 ms) 68.00 (±5.05 ms) -2.7ms (3.8%) 👌
wc-append-1k metric base(e94fcbf) target(0f174ae) trend
benchmark-table-wc/append/1k duration 257.20 (±4.95 ms) 257.05 (±6.55 ms) -0.2ms (0.1%) 👌
wc-clear-1k metric base(e94fcbf) target(0f174ae) trend
benchmark-table-wc/clear/1k duration 22.10 (±1.90 ms) 22.60 (±2.45 ms) +0.5ms (2.3%) 👌
wc-create-10k metric base(e94fcbf) target(0f174ae) trend
benchmark-table-wc/create/10k duration 2004.30 (±11.95 ms) 2034.10 (±14.25 ms) +29.8ms (1.5%) 👎
wc-create-1k metric base(e94fcbf) target(0f174ae) trend
benchmark-table-wc/create/1k duration 225.60 (±5.20 ms) 226.40 (±5.40 ms) +0.8ms (0.4%) 👌
wc-update-10th-1k metric base(e94fcbf) target(0f174ae) trend
benchmark-table-wc/update-10th/1k duration 70.90 (±5.35 ms) 73.90 (±5.80 ms) +3.0ms (4.2%) 👌

@pmdartus pmdartus merged commit 640c9b8 into master Jan 15, 2019
@pmdartus pmdartus deleted the pmdartus/fix-merge-issue-circleci branch January 15, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant