fix(jest-transformer): update @salesforce/apex transform #924
Conversation
packages/@lwc/jest-transformer/src/test/modules/example/apex/__tests__/apex.test.js
Show resolved
Hide resolved
| }); | ||
|
|
||
| describe('example-apex', () => { | ||
| it('default import is resolved Promise', () => { |
There was a problem hiding this comment.
This tests the default import eventually resolves, not that it's already resolved.
| }) | ||
| }); | ||
|
|
||
| it('can import and call multiple default Apex imports', () => { |
There was a problem hiding this comment.
This tests that a second Apex import can be called (given the context of the first test above), not that multiple Apex imports can be called.
packages/@lwc/jest-transformer/src/test/modules/example/apex/apex.js
Outdated
Show resolved
Hide resolved
|
|
||
| test('throws error if renamed default imports', ` |
There was a problem hiding this comment.
Why don't you want this or the test below?
There was a problem hiding this comment.
I removed them because we allow named imports for @salesforce/apex now. I guess we could add special logic to see if the import is renaming the default, but I'm not sure how valuable that would be.
| * shared. | ||
| */ | ||
| const resolvedPromiseTemplate = babelTemplate(` | ||
| global.MOCK_NAME = global.MOCK_NAME || function() { return Promise.resolve(); }; |
There was a problem hiding this comment.
Why not do this global assignment inside the catch on line 24 since it's only used in that code path? That avoids polluting the global var and evaluation when it's not required.
…pex.js Co-Authored-By: trevor-bliss <[email protected]>
Co-Authored-By: trevor-bliss <[email protected]>
kevinv11n
changed the title
packages/@lwc/jest-transformer/src/test/modules/example/apex/__tests__/apexWithJestMock.test.js
Outdated
Show resolved
Hide resolved
Benchmark resultsBase commit: |
Details
The
@salesforce/apexmodule import is different from the other salesforce scoped module imports for two reasons:import { refreshApex, getSObjectValue } from '@salesforce/apex';@wireadapter id.Changes in the PR are to support both cases. Additionally, there is some minor cleanup to the existing transforms logic.
Does this PR introduce a breaking change?