fix: Add crossorigin as valid img tag attribute #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsBase commit: |
caridy
approved these changes
Jan 7, 2019
caridy
suggested changes
Jan 7, 2019
There was a problem hiding this comment.
crossorigin also applies to video tag:
https://developer.mozilla.org/en-US/docs/Web/HTML/CORS_settings_attributes
Benchmark resultsBase commit: |
apapko
reviewed
Jan 7, 2019
| <!-- Issue #917 --> | ||
| <img src="http://www.example.com/image.png" crossorigin="anonymous"> | ||
| <video src="http://www.example.com/video.mp4" crossorigin="anonymous"></video> | ||
| <audio src="http://www.example.com/video.mp3" crossorigin="anonymous"></audio> |
There was a problem hiding this comment.
do we need a negative case? Per mdn, "An invalid keyword and an empty string will be handled as the anonymous keyword."
There was a problem hiding this comment.
It's not the compiler job to validate the HTML semantic, the only compiler only validates if the attribute is valid not the value.
caridy
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fix #917
Does this PR introduce a breaking change?