fix(packages): use conventional-changelog instead of lerna's conventional-commits #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-bliss
suggested changes
Jan 13, 2018
| "release:internalcanary": "yarn prepare && lerna publish --canary --skip-git --yes --registry='https://nexus.soma.salesforce.com/nexus/content/repositories/npmjs-internal/'" | ||
| "release:internalcanary": "yarn prepare && lerna publish --canary --skip-git --yes --registry='https://nexus.soma.salesforce.com/nexus/content/repositories/npmjs-internal/'", | ||
| "changelog": "yarn changelog:generate && yarn changelog:publish", | ||
| "changelog:generate": "conventional-changelog -p angular -i CHANGELOG.md -s -r 0", |
There was a problem hiding this comment.
We should add a devDependency for conventional-changelog-cli since we're using it directly now. Looks like it's getting pulled in by lerna currently.
apapko
changed the title
|
@trevor-bliss added dev-dependency for conventional-changelog-cli, please approve when you get a chance. |
trevor-bliss
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
PR Checklist
What kind of change does this PR introduce? (add 'x' - [x])
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Please check if your PR fulfills the following requirements:
The PR fulfills these requirements:
Tests for the changes have been added (for bug fixes / features)
Both unit and integration tests pass
Docs have been added / updated (for bug fixes / features)
The PR title follows conventional commit format:
commit-type(optional scope): commit description.More details on LWC semantic commit can be found here.
Other information:
Please see detailed description in the following issue