fix(module-resolver): wrong path separator in glob call #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caridy
approved these changes
Dec 19, 2018
pmdartus
reviewed
Dec 19, 2018
| @@ -34,7 +34,7 @@ function resolveModulesInDir(fullPathDir, { ignoreFolderName } = {}) { | |||
| return glob.sync(MODULE_ENTRY_PATTERN, { cwd: fullPathDir }).reduce((mappings, file) => { | |||
| const fileName = path.basename(file, MODULE_EXTENSION); | |||
| const rootDir = path.dirname(file); | |||
| const rootParts = rootDir.split(path.sep); | |||
| const rootParts = rootDir.split('/'); | |||
There was a problem hiding this comment.
Can you add a mention to the glob documentation?
This is not really obvious that glob normalize the path: https://github.com/isaacs/node-glob#windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Glob will return the matching files with forward slashes, even on windows machines.
Fixes https://github.com/salesforce/lwc-todomvc/issues/16 for Chrome. IE11 does not hit the "App is not defined" error but now gets a stackoverflow when loaded. Requires additional investigation.
Does this PR introduce a breaking change?