fix(engine): to use the later version of observable membrane

[caridy]

Details

Upgrading observable-membrane to close few holes identified by locker service folks.

Fixes #846

Does this PR introduce a breaking change?

• No

[salesforce-best-lwc-internal]

Benchmark results

Base commit: 6c1ce57 | Target commit: 1a7d3cc

lwc-engine-benchmark

table-append-1k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table/append/1k	duration	156.30 (±3.65 ms)	146.80 (±5.15 ms)	-9.5ms (6.1%) 👍

table-clear-1k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table/clear/1k	duration	6.75 (±0.35 ms)	5.90 (±0.40 ms)	-0.8ms (12.6%) 👍

table-create-10k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table/create/10k	duration	888.15 (±5.60 ms)	874.60 (±8.55 ms)	-13.5ms (1.5%) 👍

table-create-1k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table/create/1k	duration	117.75 (±2.40 ms)	114.65 (±1.65 ms)	-3.1ms (2.6%) 👍

table-update-10th-1k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table/update-10th/1k	duration	87.65 (±2.70 ms)	85.40 (±2.60 ms)	-2.3ms (2.6%) 👍

tablecmp-append-1k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table-component/append/1k	duration	259.65 (±5.20 ms)	225.65 (±15.15 ms)	-34.0ms (13.1%) 👍

tablecmp-clear-1k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table-component/clear/1k	duration	12.85 (±1.45 ms)	12.00 (±1.30 ms)	-0.9ms (6.6%) 👌

tablecmp-create-10k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table-component/create/10k	duration	1747.10 (±12.50 ms)	1747.40 (±10.15 ms)	+0.3ms (0.0%) 👌

tablecmp-create-1k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table-component/create/1k	duration	212.10 (±6.10 ms)	205.25 (±6.50 ms)	-6.8ms (3.2%) 👍

tablecmp-update-10th-1k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table-component/update-10th/1k	duration	72.90 (±4.35 ms)	68.95 (±4.85 ms)	-4.0ms (5.4%) 👍

wc-append-1k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table-wc/append/1k	duration	263.45 (±9.95 ms)	248.45 (±9.85 ms)	-15.0ms (5.7%) 👍

wc-clear-1k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table-wc/clear/1k	duration	23.15 (±2.80 ms)	22.25 (±3.00 ms)	-0.9ms (3.9%) 👍

wc-create-10k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table-wc/create/10k	duration	1890.20 (±56.05 ms)	1896.60 (±38.00 ms)	+6.4ms (0.3%) 👌

wc-create-1k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table-wc/create/1k	duration	226.65 (±4.00 ms)	219.95 (±3.60 ms)	-6.7ms (3.0%) 👍

wc-update-10th-1k	metric	base(6c1ce57)	target(1a7d3cc)	trend
benchmark-table-wc/update-10th/1k	duration	74.70 (±5.70 ms)	69.50 (±4.90 ms)	-5.2ms (7.0%) 👍

[caridy]

Some very nice perf improvements here as expected @diervo

[caridy]

@diervo I see 20 compat failures, not sure if those are the flappers, or these are real issues. Need some help here to validate.

[salesforce-best-lwc-internal]

Benchmark results

Base commit: 97bb075 | Target commit: 74f1caa

lwc-engine-benchmark

table-append-1k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table/append/1k	duration	147.55 (±4.90 ms)	147.10 (±3.85 ms)	-0.5ms (0.3%) 👌

table-clear-1k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table/clear/1k	duration	6.15 (±0.45 ms)	5.70 (±0.35 ms)	-0.5ms (7.3%) 👍

table-create-10k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table/create/10k	duration	886.10 (±6.10 ms)	879.65 (±6.25 ms)	-6.5ms (0.7%) 👍

table-create-1k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table/create/1k	duration	116.80 (±3.55 ms)	113.95 (±3.45 ms)	-2.8ms (2.4%) 👍

table-update-10th-1k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table/update-10th/1k	duration	77.00 (±2.65 ms)	75.05 (±2.20 ms)	-2.0ms (2.5%) 👍

tablecmp-append-1k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table-component/append/1k	duration	247.90 (±16.40 ms)	225.10 (±15.80 ms)	-22.8ms (9.2%) 👍

tablecmp-clear-1k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table-component/clear/1k	duration	11.30 (±1.35 ms)	11.40 (±1.70 ms)	+0.1ms (0.9%) 👌

tablecmp-create-10k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table-component/create/10k	duration	1701.95 (±13.70 ms)	1731.25 (±13.10 ms)	+29.3ms (1.7%) 👎

tablecmp-create-1k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table-component/create/1k	duration	206.90 (±4.85 ms)	205.05 (±6.05 ms)	-1.8ms (0.9%) 👌

tablecmp-update-10th-1k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table-component/update-10th/1k	duration	70.50 (±5.25 ms)	69.45 (±4.45 ms)	-1.0ms (1.5%) 👌

wc-append-1k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table-wc/append/1k	duration	251.40 (±11.10 ms)	257.70 (±7.10 ms)	+6.3ms (2.5%) 👎

wc-clear-1k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table-wc/clear/1k	duration	21.35 (±2.50 ms)	21.90 (±2.30 ms)	+0.5ms (2.6%) 👌

wc-create-10k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table-wc/create/10k	duration	1817.55 (±50.80 ms)	1880.60 (±32.80 ms)	+63.0ms (3.5%) 👎

wc-create-1k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table-wc/create/1k	duration	224.20 (±4.70 ms)	222.00 (±4.75 ms)	-2.2ms (1.0%) 👌

wc-update-10th-1k	metric	base(97bb075)	target(74f1caa)	trend
benchmark-table-wc/update-10th/1k	duration	72.85 (±6.45 ms)	69.95 (±3.45 ms)	-2.9ms (4.0%) 👍

[diervo]

We will be releasing first what we have in master and verifying internally before merging this. I will merge it once we have a clean runway

[salesforce-best-lwc-internal]

Benchmark results

Base commit: 6eb7eda | Target commit: 9a265c2

lwc-engine-benchmark

table-append-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table/append/1k	duration	155.60 (±5.65 ms)	150.65 (±5.00 ms)	-4.9ms (3.2%) 👍

table-clear-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table/clear/1k	duration	6.25 (±0.40 ms)	6.20 (±0.30 ms)	-0.0ms (0.8%) 👌

table-create-10k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table/create/10k	duration	931.65 (±5.60 ms)	877.55 (±5.50 ms)	-54.1ms (5.8%) 👍

table-create-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table/create/1k	duration	120.80 (±3.05 ms)	118.70 (±3.40 ms)	-2.1ms (1.7%) 👍

table-update-10th-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table/update-10th/1k	duration	77.15 (±3.00 ms)	74.75 (±2.85 ms)	-2.4ms (3.1%) 👍

tablecmp-append-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-component/append/1k	duration	257.45 (±8.40 ms)	242.35 (±16.70 ms)	-15.1ms (5.9%) 👍

tablecmp-clear-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-component/clear/1k	duration	12.35 (±1.55 ms)	11.85 (±1.70 ms)	-0.5ms (4.0%) 👌

tablecmp-create-10k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-component/create/10k	duration	1781.45 (±18.20 ms)	1730.90 (±17.20 ms)	-50.5ms (2.8%) 👍

tablecmp-create-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-component/create/1k	duration	214.60 (±4.70 ms)	209.70 (±6.30 ms)	-4.9ms (2.3%) 👌

tablecmp-update-10th-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-component/update-10th/1k	duration	72.40 (±5.05 ms)	70.55 (±4.45 ms)	-1.9ms (2.6%) 👌

wc-append-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-wc/append/1k	duration	261.80 (±5.55 ms)	254.15 (±5.45 ms)	-7.7ms (2.9%) 👍

wc-clear-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-wc/clear/1k	duration	23.10 (±2.30 ms)	22.10 (±1.65 ms)	-1.0ms (4.3%) 👌

wc-create-10k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-wc/create/10k	duration	2011.55 (±10.45 ms)	2003.25 (±20.95 ms)	-8.3ms (0.4%) 👍

wc-create-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-wc/create/1k	duration	229.15 (±5.10 ms)	223.65 (±3.80 ms)	-5.5ms (2.4%) 👍

wc-update-10th-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-wc/update-10th/1k	duration	73.20 (±4.50 ms)	67.95 (±4.60 ms)	-5.3ms (7.2%) 👍

[salesforce-best-lwc-internal]

Benchmark results

Base commit: 6eb7eda | Target commit: 9a265c2

lwc-engine-benchmark

table-append-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table/append/1k	duration	155.60 (±5.65 ms)	153.80 (±3.60 ms)	-1.8ms (1.2%) 👌

table-clear-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table/clear/1k	duration	6.25 (±0.40 ms)	6.60 (±0.40 ms)	+0.3ms (5.6%) 👎

table-create-10k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table/create/10k	duration	931.65 (±5.60 ms)	892.75 (±5.90 ms)	-38.9ms (4.2%) 👍

table-create-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table/create/1k	duration	120.80 (±3.05 ms)	116.50 (±2.55 ms)	-4.3ms (3.6%) 👍

table-update-10th-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table/update-10th/1k	duration	77.15 (±3.00 ms)	76.00 (±2.75 ms)	-1.2ms (1.5%) 👌

tablecmp-append-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-component/append/1k	duration	257.45 (±8.40 ms)	215.55 (±10.00 ms)	-41.9ms (16.3%) 👍

tablecmp-clear-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-component/clear/1k	duration	12.35 (±1.55 ms)	12.30 (±1.70 ms)	-0.1ms (0.4%) 👌

tablecmp-create-10k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-component/create/10k	duration	1781.45 (±18.20 ms)	1779.90 (±11.70 ms)	-1.5ms (0.1%) 👌

tablecmp-create-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-component/create/1k	duration	214.60 (±4.70 ms)	209.95 (±6.55 ms)	-4.7ms (2.2%) 👌

tablecmp-update-10th-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-component/update-10th/1k	duration	72.40 (±5.05 ms)	71.35 (±5.45 ms)	-1.1ms (1.5%) 👌

wc-append-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-wc/append/1k	duration	261.80 (±5.55 ms)	261.45 (±5.55 ms)	-0.4ms (0.1%) 👌

wc-clear-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-wc/clear/1k	duration	23.10 (±2.30 ms)	24.05 (±1.95 ms)	+0.9ms (4.1%) 👎

wc-create-10k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-wc/create/10k	duration	2011.55 (±10.45 ms)	2056.00 (±16.75 ms)	+44.5ms (2.2%) 👎

wc-create-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-wc/create/1k	duration	229.15 (±5.10 ms)	222.85 (±5.00 ms)	-6.3ms (2.7%) 👍

wc-update-10th-1k	metric	base(6eb7eda)	target(9a265c2)	trend
benchmark-table-wc/update-10th/1k	duration	73.20 (±4.50 ms)	71.50 (±5.30 ms)	-1.7ms (2.3%) 👌

[caridy]

very suspicious that we have so many compat failures now.

[salesforce-best-lwc-internal]

Benchmark results

Base commit: 0ec65ea | Target commit: 9a265c2

lwc-engine-benchmark

table-append-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table/append/1k	duration	150.60 (±5.75 ms)	147.40 (±4.10 ms)	-3.2ms (2.1%) 👌

table-clear-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table/clear/1k	duration	6.30 (±0.50 ms)	5.85 (±0.45 ms)	-0.5ms (7.1%) 👍

table-create-10k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table/create/10k	duration	910.35 (±6.40 ms)	868.65 (±6.70 ms)	-41.7ms (4.6%) 👍

table-create-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table/create/1k	duration	122.00 (±3.70 ms)	118.05 (±2.75 ms)	-3.9ms (3.2%) 👍

table-update-10th-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table/update-10th/1k	duration	86.75 (±2.25 ms)	74.40 (±2.30 ms)	-12.3ms (14.2%) 👍

tablecmp-append-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-component/append/1k	duration	256.30 (±7.85 ms)	245.25 (±9.00 ms)	-11.1ms (4.3%) 👍

tablecmp-clear-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-component/clear/1k	duration	12.40 (±1.65 ms)	11.60 (±1.85 ms)	-0.8ms (6.5%) 👌

tablecmp-create-10k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-component/create/10k	duration	1787.00 (±22.80 ms)	1746.80 (±13.40 ms)	-40.2ms (2.2%) 👍

tablecmp-create-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-component/create/1k	duration	215.30 (±4.35 ms)	212.50 (±5.80 ms)	-2.8ms (1.3%) 👍

tablecmp-update-10th-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-component/update-10th/1k	duration	70.15 (±5.25 ms)	69.30 (±5.40 ms)	-0.9ms (1.2%) 👌

wc-append-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-wc/append/1k	duration	260.60 (±5.40 ms)	257.00 (±5.40 ms)	-3.6ms (1.4%) 👌

wc-clear-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-wc/clear/1k	duration	23.00 (±1.75 ms)	21.60 (±2.10 ms)	-1.4ms (6.1%) 👍

wc-create-10k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-wc/create/10k	duration	1963.65 (±16.35 ms)	1974.85 (±13.25 ms)	+11.2ms (0.6%) 👎

wc-create-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-wc/create/1k	duration	226.05 (±5.65 ms)	219.55 (±4.95 ms)	-6.5ms (2.9%) 👍

wc-update-10th-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-wc/update-10th/1k	duration	71.10 (±5.85 ms)	68.55 (±3.75 ms)	-2.5ms (3.6%) 👌

[salesforce-best-lwc-internal]

Benchmark results

Base commit: 0ec65ea | Target commit: 9a265c2

lwc-engine-benchmark

table-append-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table/append/1k	duration	150.60 (±5.75 ms)	148.90 (±4.15 ms)	-1.7ms (1.1%) 👌

table-clear-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table/clear/1k	duration	6.30 (±0.50 ms)	5.70 (±0.30 ms)	-0.6ms (9.5%) 👍

table-create-10k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table/create/10k	duration	910.35 (±6.40 ms)	882.55 (±6.45 ms)	-27.8ms (3.1%) 👍

table-create-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table/create/1k	duration	122.00 (±3.70 ms)	115.10 (±2.35 ms)	-6.9ms (5.7%) 👍

table-update-10th-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table/update-10th/1k	duration	86.75 (±2.25 ms)	74.20 (±1.85 ms)	-12.5ms (14.5%) 👍

tablecmp-append-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-component/append/1k	duration	256.30 (±7.85 ms)	216.95 (±13.10 ms)	-39.4ms (15.4%) 👍

tablecmp-clear-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-component/clear/1k	duration	12.40 (±1.65 ms)	11.60 (±1.20 ms)	-0.8ms (6.5%) 👌

tablecmp-create-10k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-component/create/10k	duration	1787.00 (±22.80 ms)	1726.65 (±12.10 ms)	-60.3ms (3.4%) 👍

tablecmp-create-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-component/create/1k	duration	215.30 (±4.35 ms)	205.70 (±5.65 ms)	-9.6ms (4.5%) 👍

tablecmp-update-10th-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-component/update-10th/1k	duration	70.15 (±5.25 ms)	68.80 (±5.55 ms)	-1.3ms (1.9%) 👌

wc-append-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-wc/append/1k	duration	260.60 (±5.40 ms)	259.25 (±5.65 ms)	-1.4ms (0.5%) 👌

wc-clear-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-wc/clear/1k	duration	23.00 (±1.75 ms)	22.15 (±2.65 ms)	-0.9ms (3.7%) 👌

wc-create-10k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-wc/create/10k	duration	1963.65 (±16.35 ms)	1972.50 (±15.30 ms)	+8.8ms (0.5%) 👌

wc-create-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-wc/create/1k	duration	226.05 (±5.65 ms)	218.30 (±3.90 ms)	-7.8ms (3.4%) 👍

wc-update-10th-1k	metric	base(0ec65ea)	target(9a265c2)	trend
benchmark-table-wc/update-10th/1k	duration	71.10 (±5.85 ms)	69.00 (±5.35 ms)	-2.1ms (3.0%) 👍