Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove debugger statement #845

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Conversation

jodarove
Copy link
Contributor

@jodarove jodarove commented Nov 19, 2018

Does this PR introduce a breaking change?

  • Yes
  • No

@jodarove jodarove requested a review from diervo November 19, 2018 03:56
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: c9d1809 | Target commit: 627246d

lwc-engine-benchmark

table-append-1k metric base(c9d1809) target(627246d) trend
benchmark-table/append/1k duration 150.20 (±4.00 ms) 155.85 (±4.05 ms) +5.7ms (3.8%) 👎
table-clear-1k metric base(c9d1809) target(627246d) trend
benchmark-table/clear/1k duration 6.30 (±0.40 ms) 6.70 (±0.40 ms) +0.4ms (6.3%) 👎
table-create-10k metric base(c9d1809) target(627246d) trend
benchmark-table/create/10k duration 890.65 (±7.70 ms) 899.80 (±6.55 ms) +9.1ms (1.0%) 👎
table-create-1k metric base(c9d1809) target(627246d) trend
benchmark-table/create/1k duration 120.45 (±2.55 ms) 119.40 (±2.75 ms) -1.0ms (0.9%) 👌
table-update-10th-1k metric base(c9d1809) target(627246d) trend
benchmark-table/update-10th/1k duration 78.00 (±2.95 ms) 77.10 (±2.30 ms) -0.9ms (1.2%) 👌
tablecmp-append-1k metric base(c9d1809) target(627246d) trend
benchmark-table-component/append/1k duration 254.90 (±6.05 ms) 261.00 (±5.45 ms) +6.1ms (2.4%) 👎
tablecmp-clear-1k metric base(c9d1809) target(627246d) trend
benchmark-table-component/clear/1k duration 13.65 (±1.45 ms) 12.50 (±2.05 ms) -1.1ms (8.4%) 👌
tablecmp-create-10k metric base(c9d1809) target(627246d) trend
benchmark-table-component/create/10k duration 1741.95 (±10.80 ms) 1754.10 (±12.60 ms) +12.2ms (0.7%) 👎
tablecmp-create-1k metric base(c9d1809) target(627246d) trend
benchmark-table-component/create/1k duration 217.05 (±4.05 ms) 211.30 (±6.65 ms) -5.8ms (2.6%) 👍
tablecmp-update-10th-1k metric base(c9d1809) target(627246d) trend
benchmark-table-component/update-10th/1k duration 73.45 (±4.45 ms) 72.35 (±5.35 ms) -1.1ms (1.5%) 👌
wc-append-1k metric base(c9d1809) target(627246d) trend
benchmark-table-wc/append/1k duration 261.25 (±8.75 ms) 255.60 (±8.25 ms) -5.6ms (2.2%) 👍
wc-clear-1k metric base(c9d1809) target(627246d) trend
benchmark-table-wc/clear/1k duration 23.55 (±2.10 ms) 23.05 (±2.65 ms) -0.5ms (2.1%) 👌
wc-create-10k metric base(c9d1809) target(627246d) trend
benchmark-table-wc/create/10k duration 1846.40 (±49.30 ms) 1828.35 (±31.45 ms) -18.1ms (1.0%) 👌
wc-create-1k metric base(c9d1809) target(627246d) trend
benchmark-table-wc/create/1k duration 223.40 (±5.65 ms) 220.95 (±6.25 ms) -2.4ms (1.1%) 👍
wc-update-10th-1k metric base(c9d1809) target(627246d) trend
benchmark-table-wc/update-10th/1k duration 73.70 (±5.30 ms) 73.30 (±5.05 ms) -0.4ms (0.5%) 👌

@diervo diervo merged commit 6c1ce57 into master Nov 19, 2018
@diervo diervo deleted the jodarove/remove-test-debugger branch November 19, 2018 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants