fix(engine): relatedTarget event regargeting #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 15, 2018 15:29
davidturissini
changed the title
2 tasks
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
reviewed
Nov 16, 2018
| return originalTarget; | ||
| // and when an event has been added to Window | ||
| if (!(originalCurrentTarget instanceof Node)) { | ||
| return retarget(document, pathComposer(document as Node, this.composed)) as EventTarget; |
There was a problem hiding this comment.
I think the pathComposer() should be invoked with originalTarget, the retarget() is correctly invoked with the document, so, it will always report the outer most custom element as the actual target.
There was a problem hiding this comment.
I thought the same, but it looks like the correct call is:
retarget(document, pathComposer(originalTarget as Node, this.composed))
retarget will return the first match from pathComposer that exists in the same light DOM as document
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
reviewed
Nov 17, 2018
| @@ -73,7 +73,7 @@ const EventPatchDescriptors: PropertyDescriptorMap = { | |||
| // Handle cases where the currentTarget is null (for async events), | |||
| // and when an event has been added to Window | |||
| if (!(originalCurrentTarget instanceof Node)) { | |||
| return retarget(document, pathComposer(document as Node, this.composed)) as EventTarget; | |||
| return retarget(document, pathComposer(originalTarget as Node, this.composed)) as EventTarget; | |||
There was a problem hiding this comment.
since we need this anyways in both parts of the condition, maybe moving tthe pathComposer call up.
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Retargeting logic for relatedTarget
In place of #837
I don't know how, but the history on that branch got borked so easier to just open a new PR
Does this PR introduce a breaking change?
relatedTargetwill change the value it reports, which is breaking. However, I don't anticipate this being a very widely used feature so any breakages should be minimal