Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialization ie11 #828

Merged
merged 3 commits into from
Nov 13, 2018
Merged

fix: serialization ie11 #828

merged 3 commits into from
Nov 13, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Nov 13, 2018

Details

Fixing serialization of tests browser.execute

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 1996233 | Target commit: cab7ec0

lwc-engine-benchmark

table-append-1k metric base(1996233) target(cab7ec0) trend
benchmark-table/append/1k duration 159.65 (±4.30 ms) 158.00 (±4.25 ms) -1.6ms (1.0%) 👌
table-clear-1k metric base(1996233) target(cab7ec0) trend
benchmark-table/clear/1k duration 6.90 (±0.45 ms) 6.85 (±0.55 ms) -0.1ms (0.7%) 👌
table-create-10k metric base(1996233) target(cab7ec0) trend
benchmark-table/create/10k duration 936.00 (±8.25 ms) 934.25 (±7.50 ms) -1.8ms (0.2%) 👌
table-create-1k metric base(1996233) target(cab7ec0) trend
benchmark-table/create/1k duration 121.30 (±2.70 ms) 121.85 (±2.05 ms) +0.5ms (0.5%) 👌
table-update-10th-1k metric base(1996233) target(cab7ec0) trend
benchmark-table/update-10th/1k duration 91.20 (±1.35 ms) 82.80 (±5.75 ms) -8.4ms (9.2%) 👍
tablecmp-append-1k metric base(1996233) target(cab7ec0) trend
benchmark-table-component/append/1k duration 266.80 (±6.45 ms) 268.80 (±7.35 ms) +2.0ms (0.7%) 👌
tablecmp-clear-1k metric base(1996233) target(cab7ec0) trend
benchmark-table-component/clear/1k duration 13.45 (±2.10 ms) 13.30 (±1.75 ms) -0.1ms (1.1%) 👌
tablecmp-create-10k metric base(1996233) target(cab7ec0) trend
benchmark-table-component/create/10k duration 1839.05 (±15.20 ms) 1868.05 (±10.20 ms) +29.0ms (1.6%) 👎
tablecmp-create-1k metric base(1996233) target(cab7ec0) trend
benchmark-table-component/create/1k duration 216.55 (±5.85 ms) 218.10 (±5.80 ms) +1.5ms (0.7%) 👌
tablecmp-update-10th-1k metric base(1996233) target(cab7ec0) trend
benchmark-table-component/update-10th/1k duration 73.60 (±6.85 ms) 76.30 (±7.85 ms) +2.7ms (3.7%) 👌
wc-append-1k metric base(1996233) target(cab7ec0) trend
benchmark-table-wc/append/1k duration 262.10 (±16.40 ms) 274.85 (±11.50 ms) +12.8ms (4.9%) 👎
wc-clear-1k metric base(1996233) target(cab7ec0) trend
benchmark-table-wc/clear/1k duration 25.50 (±2.30 ms) 25.40 (±2.40 ms) -0.1ms (0.4%) 👌
wc-create-10k metric base(1996233) target(cab7ec0) trend
benchmark-table-wc/create/10k duration 1997.00 (±48.15 ms) 1918.95 (±34.30 ms) -78.0ms (3.9%) 👍
wc-create-1k metric base(1996233) target(cab7ec0) trend
benchmark-table-wc/create/1k duration 240.75 (±5.10 ms) 242.55 (±4.45 ms) +1.8ms (0.7%) 👎
wc-update-10th-1k metric base(1996233) target(cab7ec0) trend
benchmark-table-wc/update-10th/1k duration 77.25 (±5.55 ms) 75.90 (±5.15 ms) -1.3ms (1.7%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 1996233 | Target commit: 89fcd9d

lwc-engine-benchmark

table-append-1k metric base(1996233) target(89fcd9d) trend
benchmark-table/append/1k duration 159.65 (±4.30 ms) 155.40 (±4.05 ms) -4.2ms (2.7%) 👍
table-clear-1k metric base(1996233) target(89fcd9d) trend
benchmark-table/clear/1k duration 6.90 (±0.45 ms) 6.50 (±0.50 ms) -0.4ms (5.8%) 👍
table-create-10k metric base(1996233) target(89fcd9d) trend
benchmark-table/create/10k duration 936.00 (±8.25 ms) 941.05 (±8.00 ms) +5.0ms (0.5%) 👌
table-create-1k metric base(1996233) target(89fcd9d) trend
benchmark-table/create/1k duration 121.30 (±2.70 ms) 120.40 (±2.80 ms) -0.9ms (0.7%) 👌
table-update-10th-1k metric base(1996233) target(89fcd9d) trend
benchmark-table/update-10th/1k duration 91.20 (±1.35 ms) 82.20 (±5.90 ms) -9.0ms (9.9%) 👍
tablecmp-append-1k metric base(1996233) target(89fcd9d) trend
benchmark-table-component/append/1k duration 266.80 (±6.45 ms) 262.30 (±5.10 ms) -4.5ms (1.7%) 👍
tablecmp-clear-1k metric base(1996233) target(89fcd9d) trend
benchmark-table-component/clear/1k duration 13.45 (±2.10 ms) 13.95 (±1.80 ms) +0.5ms (3.7%) 👌
tablecmp-create-10k metric base(1996233) target(89fcd9d) trend
benchmark-table-component/create/10k duration 1839.05 (±15.20 ms) 1848.40 (±13.70 ms) +9.4ms (0.5%) 👌
tablecmp-create-1k metric base(1996233) target(89fcd9d) trend
benchmark-table-component/create/1k duration 216.55 (±5.85 ms) 216.85 (±4.35 ms) +0.3ms (0.1%) 👌
tablecmp-update-10th-1k metric base(1996233) target(89fcd9d) trend
benchmark-table-component/update-10th/1k duration 73.60 (±6.85 ms) 72.40 (±5.80 ms) -1.2ms (1.6%) 👌
wc-append-1k metric base(1996233) target(89fcd9d) trend
benchmark-table-wc/append/1k duration 262.10 (±16.40 ms) 268.20 (±10.40 ms) +6.1ms (2.3%) 👌
wc-clear-1k metric base(1996233) target(89fcd9d) trend
benchmark-table-wc/clear/1k duration 25.50 (±2.30 ms) 24.10 (±2.30 ms) -1.4ms (5.5%) 👍
wc-create-10k metric base(1996233) target(89fcd9d) trend
benchmark-table-wc/create/10k duration 1997.00 (±48.15 ms) 1956.85 (±50.45 ms) -40.2ms (2.0%) 👍
wc-create-1k metric base(1996233) target(89fcd9d) trend
benchmark-table-wc/create/1k duration 240.75 (±5.10 ms) 238.10 (±5.55 ms) -2.7ms (1.1%) 👌
wc-update-10th-1k metric base(1996233) target(89fcd9d) trend
benchmark-table-wc/update-10th/1k duration 77.25 (±5.55 ms) 74.55 (±4.80 ms) -2.7ms (3.5%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 1996233 | Target commit: a16e784

lwc-engine-benchmark

table-append-1k metric base(1996233) target(a16e784) trend
benchmark-table/append/1k duration 159.65 (±4.30 ms) 156.90 (±4.90 ms) -2.7ms (1.7%) 👌
table-clear-1k metric base(1996233) target(a16e784) trend
benchmark-table/clear/1k duration 6.90 (±0.45 ms) 6.60 (±0.40 ms) -0.3ms (4.3%) 👌
table-create-10k metric base(1996233) target(a16e784) trend
benchmark-table/create/10k duration 936.00 (±8.25 ms) 936.10 (±7.35 ms) +0.1ms (0.0%) 👌
table-create-1k metric base(1996233) target(a16e784) trend
benchmark-table/create/1k duration 121.30 (±2.70 ms) 120.75 (±2.95 ms) -0.6ms (0.5%) 👌
table-update-10th-1k metric base(1996233) target(a16e784) trend
benchmark-table/update-10th/1k duration 91.20 (±1.35 ms) 90.00 (±2.00 ms) -1.2ms (1.3%) 👍
tablecmp-append-1k metric base(1996233) target(a16e784) trend
benchmark-table-component/append/1k duration 266.80 (±6.45 ms) 265.20 (±6.45 ms) -1.6ms (0.6%) 👌
tablecmp-clear-1k metric base(1996233) target(a16e784) trend
benchmark-table-component/clear/1k duration 13.45 (±2.10 ms) 12.70 (±1.50 ms) -0.8ms (5.6%) 👌
tablecmp-create-10k metric base(1996233) target(a16e784) trend
benchmark-table-component/create/10k duration 1839.05 (±15.20 ms) 1851.05 (±11.00 ms) +12.0ms (0.7%) 👎
tablecmp-create-1k metric base(1996233) target(a16e784) trend
benchmark-table-component/create/1k duration 216.55 (±5.85 ms) 213.20 (±5.60 ms) -3.4ms (1.5%) 👍
tablecmp-update-10th-1k metric base(1996233) target(a16e784) trend
benchmark-table-component/update-10th/1k duration 73.60 (±6.85 ms) 72.35 (±5.75 ms) -1.3ms (1.7%) 👌
wc-append-1k metric base(1996233) target(a16e784) trend
benchmark-table-wc/append/1k duration 262.10 (±16.40 ms) 268.20 (±12.15 ms) +6.1ms (2.3%) 👌
wc-clear-1k metric base(1996233) target(a16e784) trend
benchmark-table-wc/clear/1k duration 25.50 (±2.30 ms) 25.25 (±2.40 ms) -0.3ms (1.0%) 👌
wc-create-10k metric base(1996233) target(a16e784) trend
benchmark-table-wc/create/10k duration 1997.00 (±48.15 ms) 1978.00 (±45.50 ms) -19.0ms (1.0%) 👌
wc-create-1k metric base(1996233) target(a16e784) trend
benchmark-table-wc/create/1k duration 240.75 (±5.10 ms) 235.65 (±4.90 ms) -5.1ms (2.1%) 👍
wc-update-10th-1k metric base(1996233) target(a16e784) trend
benchmark-table-wc/update-10th/1k duration 77.25 (±5.55 ms) 74.95 (±6.50 ms) -2.3ms (3.0%) 👌

@diervo diervo merged commit 714c4a8 into master Nov 13, 2018
@diervo diervo deleted the dval/fixTests branch November 13, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants