Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): removing aggressive assert #818

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

davidturissini
Copy link
Contributor

Details

Removes assert that is too restrictive

Does this PR introduce a breaking change?

  • Yes
  • No

@davidturissini davidturissini merged commit fdbc119 into master Nov 9, 2018
@davidturissini davidturissini deleted the dturissini/remove-restrictive-assert branch November 9, 2018 19:01
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 9a29102 | Target commit: 9f9428e

lwc-engine-benchmark

table-append-1k metric base(9a29102) target(9f9428e) trend
benchmark-table/append/1k duration 154.35 (±4.60 ms) 157.60 (±5.00 ms) +3.2ms (2.1%) 👌
table-clear-1k metric base(9a29102) target(9f9428e) trend
benchmark-table/clear/1k duration 6.35 (±0.45 ms) 6.45 (±0.50 ms) +0.1ms (1.6%) 👌
table-create-10k metric base(9a29102) target(9f9428e) trend
benchmark-table/create/10k duration 926.10 (±8.75 ms) 924.70 (±6.45 ms) -1.4ms (0.2%) 👌
table-create-1k metric base(9a29102) target(9f9428e) trend
benchmark-table/create/1k duration 119.95 (±3.10 ms) 119.70 (±3.05 ms) -0.3ms (0.2%) 👌
table-update-10th-1k metric base(9a29102) target(9f9428e) trend
benchmark-table/update-10th/1k duration 79.20 (±3.00 ms) 79.35 (±2.70 ms) +0.1ms (0.2%) 👌
tablecmp-append-1k metric base(9a29102) target(9f9428e) trend
benchmark-table-component/append/1k duration 260.00 (±4.80 ms) 262.10 (±7.05 ms) +2.1ms (0.8%) 👌
tablecmp-clear-1k metric base(9a29102) target(9f9428e) trend
benchmark-table-component/clear/1k duration 12.40 (±1.60 ms) 11.75 (±1.70 ms) -0.7ms (5.2%) 👌
tablecmp-create-10k metric base(9a29102) target(9f9428e) trend
benchmark-table-component/create/10k duration 1802.70 (±11.90 ms) 1820.85 (±13.60 ms) +18.1ms (1.0%) 👎
tablecmp-create-1k metric base(9a29102) target(9f9428e) trend
benchmark-table-component/create/1k duration 212.60 (±5.10 ms) 215.20 (±5.35 ms) +2.6ms (1.2%) 👌
tablecmp-update-10th-1k metric base(9a29102) target(9f9428e) trend
benchmark-table-component/update-10th/1k duration 74.00 (±5.60 ms) 73.95 (±5.85 ms) -0.1ms (0.1%) 👌
wc-append-1k metric base(9a29102) target(9f9428e) trend
benchmark-table-wc/append/1k duration 295.45 (±12.25 ms) 295.90 (±13.70 ms) +0.4ms (0.2%) 👌
wc-clear-1k metric base(9a29102) target(9f9428e) trend
benchmark-table-wc/clear/1k duration 25.00 (±2.90 ms) 23.80 (±2.50 ms) -1.2ms (4.8%) 👌
wc-create-10k metric base(9a29102) target(9f9428e) trend
benchmark-table-wc/create/10k duration 4507.35 (±28.45 ms) 4527.50 (±43.20 ms) +20.1ms (0.4%) 👌
wc-create-1k metric base(9a29102) target(9f9428e) trend
benchmark-table-wc/create/1k duration 265.05 (±5.70 ms) 265.90 (±6.50 ms) +0.8ms (0.3%) 👌
wc-update-10th-1k metric base(9a29102) target(9f9428e) trend
benchmark-table-wc/update-10th/1k duration 74.40 (±4.70 ms) 76.45 (±6.00 ms) +2.0ms (2.8%) 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants