Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): remove log when accessing childNodes #817

Merged
merged 1 commit into from
Nov 8, 2018
Merged

fix(engine): remove log when accessing childNodes #817

merged 1 commit into from
Nov 8, 2018

Conversation

caridy
Copy link
Contributor

@caridy caridy commented Nov 8, 2018

Details

  • we were logging an error for any access to .childNodes, but this was too aggressive considering that some browsers like IE11 will use that prop to log elements in the console. We are also consolidating the HTMLCollection and NodeList in another PR, so this is not longer an area of concern.

Does this PR introduce a breaking change?

  • No

@caridy caridy requested a review from davidturissini November 8, 2018 21:52
@caridy caridy merged commit 9a29102 into master Nov 8, 2018
@caridy caridy deleted the caridy/clean-logs branch November 8, 2018 21:59
pmdartus
pmdartus reviewed Nov 9, 2018
View reviewed changes
packages/lwc-engine/scripts/jest/test-whitelist.js
@@ -7,21 +7,10 @@
* BY ADDING A NEW ENTRY IN THIS LIST, YOU WILL BRING SHAME ON YOURSELF OVER MULTIPLE GENERATIONS!!
*/
const CONSOLE_WHITELIST = [
'#childNodes should always return an empty array for slots not rendering default content',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caridy I love this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmdartus pmdartus pmdartus left review comments

@davidturissini davidturissini davidturissini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caridy @davidturissini @pmdartus