fix(engine): fix for delegatesFocus with tabindex=0 #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidturissini
commented
Nov 7, 2018
| @@ -55,7 +55,7 @@ export function PatchedCustomElement(Base: HTMLElement): HTMLElementConstructor | |||
|
|
|||
| // Check if the value from the dom has changed | |||
| const newValue = tabIndexGetter.call(this); | |||
| if ((!hasAttr || originalValue !== newValue) && newValue === -1) { | |||
| if ((!hasAttr || originalValue !== newValue) && (newValue === -1 || (isDelegatingFocus(this) && newValue === 0))) { | |||
There was a problem hiding this comment.
If we are delegating focus, we have to listen for the focusin event if the tabindex is 0
davidturissini
commented
Nov 7, 2018
| // Host element can show up in our "previous" section if its tabindex is 0 | ||
| // We want to filter that out here | ||
| const firstChildIndex = (hostIndex > -1) ? hostIndex : ArrayIndexOf.call(all, firstChild); | ||
| const prev = ArraySlice.call(all, 0, firstChildIndex); |
There was a problem hiding this comment.
When tabindex is 0 on the host, host will actually show up in the previous array. We have to make sure that doesn't happen. I think this is quicker than using ArrayFilter call but I could be wrong.
davidturissini
commented
Nov 7, 2018
davidturissini
commented
Nov 7, 2018
| * <x-input> | ||
| * #shadowRoot(delegatesFocus=true) | ||
| * <input /> <--- focus in here | ||
| **/ |
There was a problem hiding this comment.
These comments are no longer relevant because we disqualify based on mousedown
davidturissini
commented
Nov 7, 2018
| // focuses on either the custom element, or an internal element | ||
| // via keyboard navigation (tab or shift+tab) | ||
| // Focusing via mouse should be disqualified before this gets called | ||
| function keyboardFocusInHandler(event: FocusEvent) { |
There was a problem hiding this comment.
Rename for clarity
Benchmark resultsBase commit: lwc-engine-benchmark
|
davidturissini
force-pushed
the
dturissini/delegates-focus-tabindex-zero
branch
from
e70185c to
c7d7568
Compare
caridy
approved these changes
Nov 8, 2018
davidturissini
force-pushed
the
dturissini/delegates-focus-tabindex-zero
branch
from
00a5b3e to
d667dc5
Compare
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
approved these changes
Nov 8, 2018
Benchmark resultsBase commit: lwc-engine-benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
tabindex=0anddelegatesFocuswere not actually delegating focus properly.Does this PR introduce a breaking change?