fix(engine): marking dynamic nodes as dynamic #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
approved these changes
Nov 7, 2018
ekashida
reviewed
Nov 7, 2018
| <template> | ||
| <template if:true={hasParts}> | ||
| <template for:each={text} for:item="part"> | ||
| <template if:true={part.highlight}> |
There was a problem hiding this comment.
Can we simplify this by removing part.highlight from the picture?
There was a problem hiding this comment.
Oddly enough, the bug does not exhibit when we remove this condition,
There was a problem hiding this comment.
| @@ -458,15 +458,15 @@ export function f(items: any[]): any[] { | |||
| } | |||
| const len = items.length; | |||
| const flattened: VNodes = []; | |||
|
|
|||
| // all flattened nodes should be marked as dynamic | |||
|
|
||
| it('should not render duplicate text', function () { | ||
| browser.click('integration-duplicate-text-rendering'); | ||
| assert.deepEqual(browser.getText('integration-duplicate-text-rendering'), 'b'); |
There was a problem hiding this comment.
Is it worth adding an assert.notDeepEqual() here, or maybe a comment that describes the issue that these changes fix? I'm just curious about what was actually being rendered.
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes a text rendering issue in
baseCombobobxFormattedText. Switching between an iterator and a plain text node was causing duplicate text to render.Does this PR introduce a breaking change?