Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): fix issue #766 to patch query selectors #769

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

caridy
Copy link
Contributor

@caridy caridy commented Oct 26, 2018

Details

During the last refactor, I think we mistakenly assume that Slot element should follow PatchedNode instead of PatchedElement.

Does this PR introduce a breaking change?

  • No

@@ -348,7 +348,7 @@ export function PatchedElement(elm: HTMLElement): HTMLElementConstructor {
}

export function PatchedSlotElement(elm: HTMLSlotElement): HTMLSlotElementConstructor {
const Ctor = PatchedNode(elm) as HTMLSlotElementConstructor;
const Ctor = PatchedElement(elm) as HTMLSlotElementConstructor;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and slot must extend patched element

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 22e75a5 | Target commit: fb5aeb4

lwc-engine-benchmark

table-append-1k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table/append/1k duration 149.60 (±3.90 ms) 148.10 (±3.50 ms) -1.5ms (1.0%) 👌
table-clear-1k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table/clear/1k duration 6.10 (±0.30 ms) 5.90 (±0.35 ms) -0.2ms (3.3%) 👍
table-create-10k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table/create/10k duration 861.65 (±6.30 ms) 867.00 (±7.80 ms) +5.4ms (0.6%) 👎
table-create-1k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table/create/1k duration 114.45 (±2.35 ms) 114.90 (±2.35 ms) +0.5ms (0.4%) 👌
table-update-10th-1k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table/update-10th/1k duration 77.30 (±4.35 ms) 78.40 (±4.20 ms) +1.1ms (1.4%) 👌
tablecmp-append-1k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table-component/append/1k duration 237.60 (±9.65 ms) 230.85 (±14.80 ms) -6.8ms (2.8%) 👌
tablecmp-clear-1k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table-component/clear/1k duration 12.00 (±1.50 ms) 11.55 (±1.45 ms) -0.4ms (3.7%) 👌
tablecmp-create-10k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table-component/create/10k duration 1620.80 (±9.80 ms) 1634.10 (±11.10 ms) +13.3ms (0.8%) 👎
tablecmp-create-1k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table-component/create/1k duration 199.85 (±6.30 ms) 195.75 (±5.05 ms) -4.1ms (2.1%) 👌
tablecmp-update-10th-1k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table-component/update-10th/1k duration 71.00 (±5.65 ms) 71.00 (±4.95 ms) 0.0ms (0.0%) 👌
wc-append-1k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table-wc/append/1k duration 234.25 (±11.65 ms) 230.60 (±9.65 ms) -3.7ms (1.6%) 👌
wc-clear-1k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table-wc/clear/1k duration 22.50 (±1.90 ms) 21.55 (±2.25 ms) -1.0ms (4.2%) 👌
wc-create-10k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table-wc/create/10k duration 1711.45 (±37.70 ms) 1647.55 (±66.60 ms) -63.9ms (3.7%) 👍
wc-create-1k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table-wc/create/1k duration 204.15 (±4.50 ms) 202.95 (±6.10 ms) -1.2ms (0.6%) 👌
wc-update-10th-1k metric base(22e75a5) target(fb5aeb4) trend
benchmark-table-wc/update-10th/1k duration 70.75 (±5.00 ms) 72.05 (±7.00 ms) +1.3ms (1.8%) 👌

@caridy caridy merged commit 81093fc into master Oct 26, 2018
@pmdartus pmdartus deleted the caridy/issue-766 branch December 21, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants