Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): error when event listener was on document #762

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

davidturissini
Copy link
Contributor

Details

  • Fixes issue where events added to the document were throwing error in isNodeSlotted

Does this PR introduce a breaking change?

  • Yes
  • No

// and when currentTarget is window.
if (!(currentTarget instanceof Node)) {
// and when currentTarget is window or document.
if (!(currentTarget instanceof Node) || currentTarget instanceof Document) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document is an instance of Node

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: a212efd | Target commit: 370980f

lwc-engine-benchmark

table-append-1k metric base(a212efd) target(370980f) trend
benchmark-table/append/1k duration 151.20 (±5.10 ms) 156.65 (±3.20 ms) +5.4ms (3.6%) 👎
table-clear-1k metric base(a212efd) target(370980f) trend
benchmark-table/clear/1k duration 6.50 (±0.50 ms) 6.30 (±0.40 ms) -0.2ms (3.1%) 👌
table-create-10k metric base(a212efd) target(370980f) trend
benchmark-table/create/10k duration 885.20 (±4.60 ms) 889.75 (±5.25 ms) +4.5ms (0.5%) 👎
table-create-1k metric base(a212efd) target(370980f) trend
benchmark-table/create/1k duration 114.60 (±1.80 ms) 115.85 (±2.40 ms) +1.3ms (1.1%) 👌
table-update-10th-1k metric base(a212efd) target(370980f) trend
benchmark-table/update-10th/1k duration 76.00 (±2.95 ms) 85.15 (±5.90 ms) +9.2ms (12.0%) 👎
tablecmp-append-1k metric base(a212efd) target(370980f) trend
benchmark-table-component/append/1k duration 243.45 (±9.00 ms) 221.30 (±14.10 ms) -22.1ms (9.1%) 👍
tablecmp-clear-1k metric base(a212efd) target(370980f) trend
benchmark-table-component/clear/1k duration 12.55 (±1.75 ms) 12.35 (±1.35 ms) -0.2ms (1.6%) 👌
tablecmp-create-10k metric base(a212efd) target(370980f) trend
benchmark-table-component/create/10k duration 1680.60 (±12.55 ms) 1659.55 (±8.95 ms) -21.0ms (1.3%) 👍
tablecmp-create-1k metric base(a212efd) target(370980f) trend
benchmark-table-component/create/1k duration 200.90 (±5.00 ms) 201.70 (±5.20 ms) +0.8ms (0.4%) 👌
tablecmp-update-10th-1k metric base(a212efd) target(370980f) trend
benchmark-table-component/update-10th/1k duration 71.25 (±6.65 ms) 69.20 (±4.25 ms) -2.0ms (2.9%) 👌
wc-append-1k metric base(a212efd) target(370980f) trend
benchmark-table-wc/append/1k duration 235.35 (±10.30 ms) 232.60 (±11.15 ms) -2.8ms (1.2%) 👌
wc-clear-1k metric base(a212efd) target(370980f) trend
benchmark-table-wc/clear/1k duration 23.60 (±2.55 ms) 22.40 (±2.30 ms) -1.2ms (5.1%) 👍
wc-create-10k metric base(a212efd) target(370980f) trend
benchmark-table-wc/create/10k duration 1670.65 (±65.65 ms) 1678.40 (±56.85 ms) +7.8ms (0.5%) 👌
wc-create-1k metric base(a212efd) target(370980f) trend
benchmark-table-wc/create/1k duration 204.25 (±4.75 ms) 207.10 (±4.90 ms) +2.8ms (1.4%) 👌
wc-update-10th-1k metric base(a212efd) target(370980f) trend
benchmark-table-wc/update-10th/1k duration 74.25 (±4.65 ms) 74.20 (±5.75 ms) -0.0ms (0.1%) 👌

@davidturissini davidturissini merged commit 6471a65 into master Oct 23, 2018
@davidturissini davidturissini deleted the dturissini/document-event-listener-fix branch October 23, 2018 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants