Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): updating restrictions #725

Merged
merged 2 commits into from
Oct 10, 2018

Conversation

davidturissini
Copy link
Contributor

Details

Updated documentation on restrictions

Does this PR introduce a breaking change?

  • Yes
  • No

@davidturissini davidturissini requested a review from caridy October 10, 2018 22:04
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 33ad77d | Target commit: b8fa15d

lwc-engine-benchmark

table-append-1k metric base(33ad77d) target(b8fa15d) trend
benchmark-table/append/1k duration 155.10 (±5.40 ms) 150.65 (±7.25 ms) -4.4ms (2.9%) 👌
table-clear-1k metric base(33ad77d) target(b8fa15d) trend
benchmark-table/clear/1k duration 12.10 (±1.05 ms) 11.95 (±0.55 ms) -0.2ms (1.2%) 👌
table-create-10k metric base(33ad77d) target(b8fa15d) trend
benchmark-table/create/10k duration 880.45 (±6.80 ms) 873.15 (±4.60 ms) -7.3ms (0.8%) 👍
table-create-1k metric base(33ad77d) target(b8fa15d) trend
benchmark-table/create/1k duration 109.10 (±2.20 ms) 108.20 (±1.80 ms) -0.9ms (0.8%) 👌
table-update-10th-1k metric base(33ad77d) target(b8fa15d) trend
benchmark-table/update-10th/1k duration 84.55 (±1.55 ms) 84.15 (±1.55 ms) -0.4ms (0.5%) 👌
tablecmp-append-1k metric base(33ad77d) target(b8fa15d) trend
benchmark-table-component/append/1k duration 228.90 (±6.95 ms) 207.95 (±18.70 ms) -21.0ms (9.2%) 👍
tablecmp-clear-1k metric base(33ad77d) target(b8fa15d) trend
benchmark-table-component/clear/1k duration 19.70 (±1.60 ms) 19.15 (±2.40 ms) -0.6ms (2.8%) 👌
tablecmp-create-10k metric base(33ad77d) target(b8fa15d) trend
benchmark-table-component/create/10k duration 1587.05 (±9.10 ms) 1585.40 (±9.95 ms) -1.6ms (0.1%) 👌
tablecmp-create-1k metric base(33ad77d) target(b8fa15d) trend
benchmark-table-component/create/1k duration 185.00 (±5.00 ms) 182.40 (±6.50 ms) -2.6ms (1.4%) 👍
tablecmp-update-10th-1k metric base(33ad77d) target(b8fa15d) trend
benchmark-table-component/update-10th/1k duration 80.70 (±5.95 ms) 79.90 (±5.50 ms) -0.8ms (1.0%) 👌
wc-append-1k metric base(33ad77d) target(b8fa15d) trend
benchmark-table-wc/append/1k duration 266.85 (±12.55 ms) 268.15 (±12.05 ms) +1.3ms (0.5%) 👌
wc-clear-1k metric base(33ad77d) target(b8fa15d) trend
benchmark-table-wc/clear/1k duration 29.10 (±1.85 ms) 27.20 (±1.60 ms) -1.9ms (6.5%) 👍
wc-create-10k metric base(33ad77d) target(b8fa15d) trend
benchmark-table-wc/create/10k duration 2058.65 (±11.45 ms) 2068.65 (±16.40 ms) +10.0ms (0.5%) 👎
wc-create-1k metric base(33ad77d) target(b8fa15d) trend
benchmark-table-wc/create/1k duration 220.05 (±4.60 ms) 221.40 (±3.75 ms) +1.3ms (0.6%) 👌
wc-update-10th-1k metric base(33ad77d) target(b8fa15d) trend
benchmark-table-wc/update-10th/1k duration 81.30 (±5.70 ms) 83.40 (±6.30 ms) +2.1ms (2.6%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 33ad77d | Target commit: a40aa1c

lwc-engine-benchmark

table-append-1k metric base(33ad77d) target(a40aa1c) trend
benchmark-table/append/1k duration 155.10 (±5.40 ms) 152.90 (±6.30 ms) -2.2ms (1.4%) 👌
table-clear-1k metric base(33ad77d) target(a40aa1c) trend
benchmark-table/clear/1k duration 12.10 (±1.05 ms) 11.95 (±0.80 ms) -0.2ms (1.2%) 👌
table-create-10k metric base(33ad77d) target(a40aa1c) trend
benchmark-table/create/10k duration 880.45 (±6.80 ms) 868.00 (±6.90 ms) -12.5ms (1.4%) 👍
table-create-1k metric base(33ad77d) target(a40aa1c) trend
benchmark-table/create/1k duration 109.10 (±2.20 ms) 108.15 (±2.05 ms) -0.9ms (0.9%) 👌
table-update-10th-1k metric base(33ad77d) target(a40aa1c) trend
benchmark-table/update-10th/1k duration 84.55 (±1.55 ms) 93.20 (±6.15 ms) +8.6ms (10.2%) 👎
tablecmp-append-1k metric base(33ad77d) target(a40aa1c) trend
benchmark-table-component/append/1k duration 228.90 (±6.95 ms) 226.60 (±8.05 ms) -2.3ms (1.0%) 👌
tablecmp-clear-1k metric base(33ad77d) target(a40aa1c) trend
benchmark-table-component/clear/1k duration 19.70 (±1.60 ms) 18.45 (±2.05 ms) -1.2ms (6.3%) 👌
tablecmp-create-10k metric base(33ad77d) target(a40aa1c) trend
benchmark-table-component/create/10k duration 1587.05 (±9.10 ms) 1599.10 (±12.00 ms) +12.0ms (0.8%) 👎
tablecmp-create-1k metric base(33ad77d) target(a40aa1c) trend
benchmark-table-component/create/1k duration 185.00 (±5.00 ms) 183.20 (±5.25 ms) -1.8ms (1.0%) 👌
tablecmp-update-10th-1k metric base(33ad77d) target(a40aa1c) trend
benchmark-table-component/update-10th/1k duration 80.70 (±5.95 ms) 79.15 (±4.50 ms) -1.5ms (1.9%) 👌
wc-append-1k metric base(33ad77d) target(a40aa1c) trend
benchmark-table-wc/append/1k duration 266.85 (±12.55 ms) 265.00 (±11.90 ms) -1.9ms (0.7%) 👌
wc-clear-1k metric base(33ad77d) target(a40aa1c) trend
benchmark-table-wc/clear/1k duration 29.10 (±1.85 ms) 28.05 (±2.90 ms) -1.1ms (3.6%) 👌
wc-create-10k metric base(33ad77d) target(a40aa1c) trend
benchmark-table-wc/create/10k duration 2058.65 (±11.45 ms) 2069.50 (±12.70 ms) +10.8ms (0.5%) 👎
wc-create-1k metric base(33ad77d) target(a40aa1c) trend
benchmark-table-wc/create/1k duration 220.05 (±4.60 ms) 218.35 (±5.60 ms) -1.7ms (0.8%) 👌
wc-update-10th-1k metric base(33ad77d) target(a40aa1c) trend
benchmark-table-wc/update-10th/1k duration 81.30 (±5.70 ms) 83.95 (±5.00 ms) +2.6ms (3.3%) 👌

@davidturissini davidturissini merged commit 81e8c2b into master Oct 10, 2018
@davidturissini davidturissini deleted the dturissini/update-closed-restriction branch October 10, 2018 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants