fix(engine): fixes issue #710 - add better error for invalid template #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caridy
commented
Oct 7, 2018
|
|
||
| export function isTemplateRegistered(tmpl: Template) { | ||
| if (!VERIFIED_TEMPLATE_SET.has(tmpl)) { | ||
| throw new TypeError('Unknown template'); |
There was a problem hiding this comment.
moving the throwing logic to the invoker of this method to we have access to the vm, and other details of the component to provide better message.
caridy
commented
Oct 7, 2018
| @@ -1,14 +1,14 @@ | |||
| import { Template } from "./template"; | |||
|
|
|||
| const VERIFIED_TEMPLATE_SET = new Set(); | |||
| const signedTemplateSet: Set<Template> = new Set(); | |||
There was a problem hiding this comment.
just renaming and typing
caridy
commented
Oct 7, 2018
| * List of property names that are accessed of the component instance | ||
| * from the template. | ||
| */ | ||
| ids?: string[]; |
There was a problem hiding this comment.
this interface was incompleted, surfaced the issue after adding the proper type to the html argument in validateFields
caridy
commented
Oct 7, 2018
| isTemplateRegistered(html); | ||
| // Check that the template was built by the compiler | ||
| if (!isTemplateRegistered(html)) { | ||
| throw new ReferenceError(`The template rendered by ${vm} must return an imported template tag (e.g.: \`import html from "./${vm.def.name}.html"\`) or undefined, instead, it has returned a function.`); |
There was a problem hiding this comment.
We don't need to add the component stack here since the invocation of this function is inside a try/catch in invoker, that's the one that will add the error details.
Benchmark resultsBase commit: lwc-engine-benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Follow up PR after PR #693
Does this PR introduce a breaking change?