Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): integration flapper - async-event-target #715

Merged
merged 3 commits into from
Oct 7, 2018

Conversation

caridy
Copy link
Contributor

@caridy caridy commented Oct 7, 2018

Details

Attempting to fix the flapper :(

Does this PR introduce a breaking change?

  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: cbf27e1 | Target commit: 6e31051

lwc-engine-benchmark

table-append-1k metric base(cbf27e1) target(6e31051) trend
benchmark-table/append/1k duration 154.70 (±5.25 ms) 152.85 (±6.30 ms) -1.8ms (1.2%) 👍
table-clear-1k metric base(cbf27e1) target(6e31051) trend
benchmark-table/clear/1k duration 12.20 (±0.75 ms) 12.35 (±0.65 ms) +0.2ms (1.2%) 👌
table-create-10k metric base(cbf27e1) target(6e31051) trend
benchmark-table/create/10k duration 871.15 (±7.20 ms) 881.35 (±8.35 ms) +10.2ms (1.2%) 👎
table-create-1k metric base(cbf27e1) target(6e31051) trend
benchmark-table/create/1k duration 108.40 (±2.45 ms) 109.65 (±2.15 ms) +1.3ms (1.2%) 👌
table-update-10th-1k metric base(cbf27e1) target(6e31051) trend
benchmark-table/update-10th/1k duration 84.65 (±2.05 ms) 96.95 (±5.00 ms) +12.3ms (14.5%) 👎
tablecmp-append-1k metric base(cbf27e1) target(6e31051) trend
benchmark-table-component/append/1k duration 232.25 (±6.30 ms) 221.80 (±12.20 ms) -10.4ms (4.5%) 👍
tablecmp-clear-1k metric base(cbf27e1) target(6e31051) trend
benchmark-table-component/clear/1k duration 18.80 (±1.55 ms) 19.55 (±2.00 ms) +0.8ms (4.0%) 👌
tablecmp-create-10k metric base(cbf27e1) target(6e31051) trend
benchmark-table-component/create/10k duration 1617.10 (±10.40 ms) 1595.15 (±10.10 ms) -21.9ms (1.4%) 👍
tablecmp-create-1k metric base(cbf27e1) target(6e31051) trend
benchmark-table-component/create/1k duration 183.60 (±7.40 ms) 181.05 (±5.65 ms) -2.6ms (1.4%) 👌
tablecmp-update-10th-1k metric base(cbf27e1) target(6e31051) trend
benchmark-table-component/update-10th/1k duration 81.35 (±5.30 ms) 82.45 (±5.10 ms) +1.1ms (1.4%) 👌
wc-append-1k metric base(cbf27e1) target(6e31051) trend
benchmark-table-wc/append/1k duration 275.10 (±9.20 ms) 272.40 (±16.65 ms) -2.7ms (1.0%) 👌
wc-clear-1k metric base(cbf27e1) target(6e31051) trend
benchmark-table-wc/clear/1k duration 30.45 (±2.35 ms) 28.65 (±2.35 ms) -1.8ms (5.9%) 👍
wc-create-10k metric base(cbf27e1) target(6e31051) trend
benchmark-table-wc/create/10k duration 2049.45 (±14.20 ms) 2046.90 (±11.30 ms) -2.5ms (0.1%) 👌
wc-create-1k metric base(cbf27e1) target(6e31051) trend
benchmark-table-wc/create/1k duration 223.30 (±7.15 ms) 222.80 (±6.50 ms) -0.5ms (0.2%) 👌
wc-update-10th-1k metric base(cbf27e1) target(6e31051) trend
benchmark-table-wc/update-10th/1k duration 81.65 (±5.60 ms) 81.55 (±6.30 ms) -0.1ms (0.1%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: cbf27e1 | Target commit: 1cb4ae0

lwc-engine-benchmark

table-append-1k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table/append/1k duration 154.70 (±5.25 ms) 157.15 (±6.30 ms) +2.4ms (1.6%) 👎
table-clear-1k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table/clear/1k duration 12.20 (±0.75 ms) 12.40 (±0.85 ms) +0.2ms (1.6%) 👌
table-create-10k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table/create/10k duration 871.15 (±7.20 ms) 880.40 (±6.60 ms) +9.3ms (1.1%) 👎
table-create-1k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table/create/1k duration 108.40 (±2.45 ms) 111.25 (±2.50 ms) +2.8ms (2.6%) 👎
table-update-10th-1k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table/update-10th/1k duration 84.65 (±2.05 ms) 84.90 (±1.30 ms) +0.3ms (0.3%) 👌
tablecmp-append-1k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table-component/append/1k duration 232.25 (±6.30 ms) 211.05 (±8.55 ms) -21.2ms (9.1%) 👍
tablecmp-clear-1k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table-component/clear/1k duration 18.80 (±1.55 ms) 20.20 (±1.80 ms) +1.4ms (7.4%) 👌
tablecmp-create-10k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table-component/create/10k duration 1617.10 (±10.40 ms) 1590.60 (±11.40 ms) -26.5ms (1.6%) 👍
tablecmp-create-1k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table-component/create/1k duration 183.60 (±7.40 ms) 185.25 (±5.95 ms) +1.6ms (0.9%) 👌
tablecmp-update-10th-1k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table-component/update-10th/1k duration 81.35 (±5.30 ms) 81.40 (±6.20 ms) +0.1ms (0.1%) 👌
wc-append-1k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table-wc/append/1k duration 275.10 (±9.20 ms) 276.70 (±15.00 ms) +1.6ms (0.6%) 👌
wc-clear-1k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table-wc/clear/1k duration 30.45 (±2.35 ms) 29.40 (±2.70 ms) -1.1ms (3.4%) 👌
wc-create-10k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table-wc/create/10k duration 2049.45 (±14.20 ms) 2075.75 (±13.95 ms) +26.3ms (1.3%) 👎
wc-create-1k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table-wc/create/1k duration 223.30 (±7.15 ms) 223.90 (±5.65 ms) +0.6ms (0.3%) 👌
wc-update-10th-1k metric base(cbf27e1) target(1cb4ae0) trend
benchmark-table-wc/update-10th/1k duration 81.65 (±5.60 ms) 84.70 (±6.45 ms) +3.0ms (3.7%) 👌

@diervo diervo merged commit 6a7de86 into master Oct 7, 2018
@diervo diervo deleted the caridy/fix-flapper-async-event-target branch October 7, 2018 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants