Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zindex optimization in prod #690

Merged
merged 1 commit into from
Sep 29, 2018
Merged

fix: zindex optimization in prod #690

merged 1 commit into from
Sep 29, 2018

Conversation

pmdartus
Copy link
Member

Details

Fix #689

Does this PR introduce a breaking change?

  • Yes
  • No

@pmdartus pmdartus requested a review from apapko September 28, 2018 23:55
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 648922f | Target commit: 8d718aa

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 648922f | Target commit: 8d718aa

lwc-engine-benchmark

table-append-1k metric base(648922f) target(8d718aa) trend
benchmark-table/append/1k duration 159.60 (±4.85 ms) 158.70 (±5.25 ms) -0.9ms (0.6%) 👌
table-clear-1k metric base(648922f) target(8d718aa) trend
benchmark-table/clear/1k duration 12.50 (±0.90 ms) 12.00 (±0.75 ms) -0.5ms (4.0%) 👌
table-create-10k metric base(648922f) target(8d718aa) trend
benchmark-table/create/10k duration 940.40 (±7.40 ms) 951.70 (±10.45 ms) +11.3ms (1.2%) 👎
table-create-1k metric base(648922f) target(8d718aa) trend
benchmark-table/create/1k duration 111.05 (±2.15 ms) 111.35 (±2.00 ms) +0.3ms (0.3%) 👌
table-update-10th-1k metric base(648922f) target(8d718aa) trend
benchmark-table/update-10th/1k duration 97.90 (±3.10 ms) 98.65 (±4.00 ms) +0.8ms (0.8%) 👌
tablecmp-append-1k metric base(648922f) target(8d718aa) trend
benchmark-table-component/append/1k duration 239.75 (±6.80 ms) 242.65 (±5.90 ms) +2.9ms (1.2%) 👌
tablecmp-clear-1k metric base(648922f) target(8d718aa) trend
benchmark-table-component/clear/1k duration 20.30 (±2.35 ms) 20.90 (±2.30 ms) +0.6ms (3.0%) 👌
tablecmp-create-10k metric base(648922f) target(8d718aa) trend
benchmark-table-component/create/10k duration 1644.60 (±12.55 ms) 1656.00 (±15.60 ms) +11.4ms (0.7%) 👎
tablecmp-create-1k metric base(648922f) target(8d718aa) trend
benchmark-table-component/create/1k duration 184.80 (±6.70 ms) 182.90 (±5.70 ms) -1.9ms (1.0%) 👌
tablecmp-update-10th-1k metric base(648922f) target(8d718aa) trend
benchmark-table-component/update-10th/1k duration 84.60 (±5.85 ms) 84.90 (±5.65 ms) +0.3ms (0.4%) 👌
wc-append-1k metric base(648922f) target(8d718aa) trend
benchmark-table-wc/append/1k duration 281.70 (±9.10 ms) 271.25 (±18.25 ms) -10.5ms (3.7%) 👌
wc-clear-1k metric base(648922f) target(8d718aa) trend
benchmark-table-wc/clear/1k duration 28.75 (±3.00 ms) 28.10 (±3.50 ms) -0.6ms (2.3%) 👌
wc-create-10k metric base(648922f) target(8d718aa) trend
benchmark-table-wc/create/10k duration 2139.00 (±17.80 ms) 2147.85 (±9.75 ms) +8.8ms (0.4%) 👎
wc-create-1k metric base(648922f) target(8d718aa) trend
benchmark-table-wc/create/1k duration 225.05 (±4.45 ms) 223.35 (±5.20 ms) -1.7ms (0.8%) 👌
wc-update-10th-1k metric base(648922f) target(8d718aa) trend
benchmark-table-wc/update-10th/1k duration 83.30 (±5.25 ms) 84.55 (±8.25 ms) +1.3ms (1.5%) 👌

@pmdartus pmdartus merged commit 88f3dcd into master Sep 29, 2018
@pmdartus pmdartus deleted the pmdartus/fix-zindex branch October 1, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants