fix(engine): bug introduced that breaks circular on proto chain #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caridy
commented
Jul 13, 2018
| @@ -96,7 +96,7 @@ const CtorToDefMap: WeakMap<any, ComponentDef> = new WeakMap(); | |||
|
|
|||
| function getCtorProto(Ctor: any): any { | |||
| const proto = getPrototypeOf(Ctor); | |||
| return isCircularModuleDependency(Ctor) ? resolveCircularModuleDependency(proto) : proto; | |||
| return isCircularModuleDependency(proto) ? resolveCircularModuleDependency(proto) : proto; | |||
There was a problem hiding this comment.
nobody saw the issue in the review :( and it was pretty clear that this was wrong.
There was a problem hiding this comment.
Perhaps it's worth adding comments here why the resolution works as it is or at least moving the method comments from resolveCircularModuleDependency function here, so that the developer can have a bigger picture on the prototype is retrieved.
There was a problem hiding this comment.
@caridy It was a review of dozens of files and million changes...
apapko
approved these changes
Jul 13, 2018
diervo
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I broke this one a week ago when changing the detection of circular references.
Does this PR introduce a breaking change?