fix(wire-service): error with invalid adapter id #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsBase commit: lwc-engine-benchmark
|
kevinv11n
force-pushed
the
kv/wire-service-errors-on-nonexistent-adapter
branch
from
747e58c to
cf26759
Compare
In non-prod mode, throw an error when the adapter is is invalid: non-truthy or unregistered
kevinv11n
force-pushed
the
kv/wire-service-errors-on-nonexistent-adapter
branch
from
cf26759 to
9a7d2be
Compare
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
kevinv11n
commented
Jul 7, 2018
| if (process.env.NODE_ENV !== 'production') { | ||
| assert.isTrue(wireDef.adapter, `@wire on "${wireTarget}": adapter id must be truthy`); | ||
| assert.isTrue(adapterFactory, `@wire on "${wireTarget}": unknown adapter id: ${String(wireDef.adapter)}`); | ||
| } |
There was a problem hiding this comment.
This is the real change: in non-prod, assert adapter id is truthy and registered (so adapterFactory exists)
kevinv11n
commented
Jul 7, 2018
| if (process.env.NODE_ENV !== 'production') { | ||
| assert.isTrue(adapterId, 'adapter id must be truthy'); | ||
| assert.isTrue(typeof adapterFactory === 'function', 'adapter factory must be a callable'); | ||
| } |
There was a problem hiding this comment.
Move existing asserts under mode check so they're removed in prod
kevinv11n
commented
Jul 7, 2018
| assert.isFalse(connectedListeners.includes(listener as NoArgumentListener), 'must not call addEventListener("connect") with the same listener'); | ||
| if (process.env.NODE_ENV !== 'production') { | ||
| assert.isFalse(connectedListeners.includes(listener as NoArgumentListener), 'must not call addEventListener("connect") with the same listener'); | ||
| } |
There was a problem hiding this comment.
Same with these existing asserts
diervo
approved these changes
Jul 7, 2018
caridy
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a breaking change?