feat(jest-transformer): Add babel transform for new scoped imports #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsBase commit: |
kevinv11n
suggested changes
Jul 2, 2018
| import { default as label } from '@salesforce/apex/FooController.fooMethod'; | ||
| `, undefined, 'Invalid import from @salesforce/apex/FooController.fooMethod'); | ||
|
|
||
| test('throws error if renamed multipel default imports', ` |
| } catch (e) { | ||
| objectApiName = { | ||
| objectApiName: "Opportunity", | ||
| fieldApiName: undefined |
There was a problem hiding this comment.
We shouldn't provision fieldApiName on an object import
| } | ||
| `); | ||
|
|
||
| const schemaObjectTemplate = babelTemplate(` |
There was a problem hiding this comment.
We need two templates:
- schemaObject that returns
{objectApiName} - schemaField that returns
{objectApiName, fieldApiName}
[1] is used for import x from @salesforce/schema/<word>
[2] is used for import x from @salesforce/schema/<word>[.<word>]+
| const resourcePath = importSource.substring(importIdentifier.length + 1); | ||
| const idx = resourcePath.indexOf('.'); | ||
|
|
||
| if (idx === -1) { |
There was a problem hiding this comment.
This logic needs tweaking per comment above. It's also the place you can pivot the logic.
added 2 commits
July 2, 2018 15:31
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
kevinv11n
approved these changes
Jul 2, 2018
| @@ -18,7 +18,16 @@ const resolvedPromiseTemplate = babelTemplate(` | |||
| } | |||
| `); | |||
|
|
|||
| const schemaObjectTemplate = babelTemplate(` | |||
| const schemaSObjectTemplate = babelTemplate(` | |||
There was a problem hiding this comment.
Can we call these schemaObjectTemplate and schemaObjectAndFieldTemplate? In the future there will be other templates (eg field sets).
kevinv11n
approved these changes
Jul 2, 2018
Benchmark resultsBase commit: lwc-engine-benchmark
|
pmdartus
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
As part of the work to fold scoped module imports all under
@salesforce, we need to update the Jest transformer to handle the new imports in a similar way that@labelis handled so tests do not error on load. The transformation for the new imports follows the same pattern as@label, but may provide a different fallback value depending on the import type.Does this PR introduce a breaking change?