Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing npm dependency. Allow dynamic imports #461

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Jul 2, 2018

Details

  • Adding camelcase npm package
  • Allowing dynamic imports syntax (follow up with lint rule)

Does this PR introduce a breaking change?

  • No

@kevinv11n
Copy link
Contributor

Dynamic imports concern me because of performance issues and complexity of components that may result. Is there a doc outlining the larger plan for this?

@diervo
Copy link
Contributor Author

diervo commented Jul 2, 2018

@kevinv11n The idea is that the standalone compiler should not block dynamic imports. The SFDC compiler and our linting should as we build the invariants and rules around this.

Moreover, without this its very hard to prototype anything in standalone apps since the compiler will throw.

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 779fd9d | Target commit: e695667

lwc-engine-benchmark

table-append-1k metric base(779fd9d) target(e695667) trend
benchmark-table/append/1k duration 155.40 (± 5.50 ms) 153.80 (± 6.30 ms) 1.03% 👌
table-clear-1k metric base(779fd9d) target(e695667) trend
benchmark-table/clear/1k duration 11.90 (± 0.60 ms) 12.40 (± 0.80 ms) -4.20% 👎
table-create-10k metric base(779fd9d) target(e695667) trend
benchmark-table/create/10k duration 903.40 (± 12.60 ms) 887.40 (± 9.60 ms) 1.77% 👍
table-create-1k metric base(779fd9d) target(e695667) trend
benchmark-table/create/1k duration 103.20 (± 1.60 ms) 102.50 (± 1.80 ms) 0.68% 👌
table-update-10th-1k metric base(779fd9d) target(e695667) trend
benchmark-table/update-10th/1k duration 87.40 (± 4.80 ms) 89.70 (± 5.00 ms) -2.63% 👌
tablecmp-append-1k metric base(779fd9d) target(e695667) trend
benchmark-table-component/append/1k duration 233.80 (± 4.40 ms) 231.30 (± 6.40 ms) 1.07% 👌
tablecmp-clear-1k metric base(779fd9d) target(e695667) trend
benchmark-table/clear/1k duration 37.40 (± 2.50 ms) 36.15 (± 1.85 ms) 3.34% 👍
tablecmp-create-10k metric base(779fd9d) target(e695667) trend
benchmark-table-component/create/10k duration 1620.60 (± 10.60 ms) 1605.70 (± 8.90 ms) 0.92% 👍
tablecmp-create-1k metric base(779fd9d) target(e695667) trend
benchmark-table-component/create/1k duration 173.70 (± 3.95 ms) 176.60 (± 3.80 ms) -1.67% 👌
tablecmp-update-10th-1k metric base(779fd9d) target(e695667) trend
benchmark-table-component/update-10th/1k duration 80.50 (± 5.30 ms) 76.90 (± 4.60 ms) 4.47% 👌

@diervo diervo merged commit 651494c into master Jul 2, 2018
@diervo diervo deleted the dval/upgradeTemplateCompiler branch July 2, 2018 16:52
@caridy
Copy link
Contributor

caridy commented Jul 3, 2018

Even though I agree with this PR. I do think that dynamic import in platform will require transformation (for the cases that we want to support). But let's discuss that somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants